public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.33-rc3-mmotm0106 - BUG: MAX_LOCKDEP_KEYS too low!
Date: Wed, 13 Jan 2010 14:28:08 +0100	[thread overview]
Message-ID: <1263389288.4244.222.camel@laptop> (raw)
In-Reply-To: <30283.1263363729@localhost>

On Wed, 2010-01-13 at 01:22 -0500, Valdis.Kletnieks@vt.edu wrote:
> Seen in my dmesg output - I wasn't even home at the time, so my
> laptop was basically idle.
> 
> [ 7777.019267] dell-wmi: Received unknown WMI event (0x11)
> [ 8190.620401] BUG: MAX_LOCKDEP_KEYS too low!

> If I'm hitting MAX_LOCKDEP_KEYS after just a few hours on a mostly-idle
> laptop, should it be set higher?

I'm wondering what's eating all those classes, it there a lot of module
loading/unloading happening?

Does something like the below give any clues?

---
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 5feaddc..90b9428 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -761,6 +761,7 @@ register_lock_class(struct lockdep_map *lock,
unsigned int subclass, int force)
 	debug_atomic_inc(&nr_unused_locks);
 	class->key = key;
 	class->name = lock->name;
+	printk(KERN_EMERG "LOCK CLASS: %s\n", lock->name);
 	class->subclass = subclass;
 	INIT_LIST_HEAD(&class->lock_entry);
 	INIT_LIST_HEAD(&class->locks_before);



      reply	other threads:[~2010-01-13 13:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13  6:22 2.6.33-rc3-mmotm0106 - BUG: MAX_LOCKDEP_KEYS too low! Valdis.Kletnieks
2010-01-13 13:28 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263389288.4244.222.camel@laptop \
    --to=peterz@infradead.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox