From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/3] rbtree: Introduce rb_for_each_entry
Date: Wed, 13 Jan 2010 14:36:37 +0100 [thread overview]
Message-ID: <1263389797.4244.223.camel@laptop> (raw)
In-Reply-To: <20100113133442.GB5036@nowhere>
On Wed, 2010-01-13 at 14:34 +0100, Frederic Weisbecker wrote:
> On Wed, Jan 13, 2010 at 02:16:09PM +0100, Peter Zijlstra wrote:
> > On Wed, 2010-01-13 at 11:01 -0200, Arnaldo Carvalho de Melo wrote:
> > > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > >
> > > Similar to list_for_each_entry, helps reducing boilerplate in many
> > > places and makes rbtrees closer to list.h macros.
> > >
> > > First conversion will be in the tools/perf.
> >
> > I'm still not sure you really want to do this, it might give people the
> > impression its a sane thing to do ;-)
>
>
> At least it matches many patterns in perf :)
Doesn't make it right.
next prev parent reply other threads:[~2010-01-13 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 13:01 [PATCH 1/3] rbtree: Introduce rb_for_each_entry Arnaldo Carvalho de Melo
2010-01-13 13:01 ` [PATCH 2/3] perf tools: Use rb_for_each_entry Arnaldo Carvalho de Melo
2010-01-13 13:01 ` [PATCH 3/3] perf tools: Encode kernel module mappings in perf.data Arnaldo Carvalho de Melo
2010-01-13 13:16 ` [PATCH 1/3] rbtree: Introduce rb_for_each_entry Peter Zijlstra
2010-01-13 13:34 ` Frederic Weisbecker
2010-01-13 13:36 ` Peter Zijlstra [this message]
2010-01-13 13:52 ` Arnaldo Carvalho de Melo
2010-01-13 13:58 ` Peter Zijlstra
2010-01-13 14:13 ` Arnaldo Carvalho de Melo
2010-01-13 14:18 ` Peter Zijlstra
2010-01-13 14:22 ` Arnaldo Carvalho de Melo
2010-01-13 14:28 ` Frederic Weisbecker
2010-01-13 15:26 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263389797.4244.223.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox