public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Driver-Core: require valid action string in uevent trigger
@ 2010-01-14 21:54 Kay Sievers
  0 siblings, 0 replies; only message in thread
From: Kay Sievers @ 2010-01-14 21:54 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel

From: Kay Sievers <kay.sievers@vrfy.org>
Subject: Driver-Core: require valid action string in uevent trigger

No longer fall back to "add" and warn, but always require a valid
action-string written to the "uevent" file. 

Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
---
 drivers/base/core.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -306,15 +306,10 @@ static ssize_t store_uevent(struct devic
 {
 	enum kobject_action action;
 
-	if (kobject_action_type(buf, count, &action) == 0) {
+	if (kobject_action_type(buf, count, &action) == 0)
 		kobject_uevent(&dev->kobj, action);
-		goto out;
-	}
-
-	dev_err(dev, "uevent: unsupported action-string; this will "
-		     "be ignored in a future kernel version\n");
-	kobject_uevent(&dev->kobj, KOBJ_ADD);
-out:
+	else
+		dev_err(dev, "uevent: unknown action-string\n");
 	return count;
 }
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-14 21:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 21:54 Driver-Core: require valid action string in uevent trigger Kay Sievers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox