From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: Alex Deucher <alexdeucher@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@redhat.com>
Subject: Re: drm/radeon/kms: fix up LVDS handling on macs (v2)
Date: Fri, 15 Jan 2010 14:35:56 +1100 [thread overview]
Message-ID: <1263526556.724.402.camel@pasglop> (raw)
In-Reply-To: <1263463781.3544.4714.camel@thor>
On Thu, 2010-01-14 at 11:09 +0100, Michel Dänzer wrote:
> I have looked at radeonfb for a patch I posted a while ago to expose a
> backlight class device with KMS, and I can only see what you describe
> above affecting the LVDS_GEN_CNTL backlight level, not BLON or
> BL_MOD_EN. Am I missing something?
No, you aren't, it's radeonfb who is :-) I never quite got that part
right. I was somewhat hoping several times that Hui and then Alex would
manage to dig some info from ATI about what the right method is to drive
those panels I think :-)
But my observation on those HW was definitely that when inverted,
disabling the modulation was also turning the panel to full bright on,
rather than turning it off.
> Without my patch, KMS doesn't change the backlight level at all, so
> assuming the firmware manages to enable the backlight, it should stay
> like that.
Your patch might make things better than they are today, I'm not arguing
there :-) I'm just saying that now might be a good time to try to sort
out exactly what should be done in there :-)
Cheers,
Ben.
next prev parent reply other threads:[~2010-01-15 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201001140059.o0E0x4wS006650@hera.kernel.org>
2010-01-14 2:45 ` drm/radeon/kms: fix up LVDS handling on macs (v2) Benjamin Herrenschmidt
2010-01-14 10:09 ` Michel Dänzer
2010-01-15 3:35 ` Benjamin Herrenschmidt [this message]
2010-01-15 13:49 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263526556.724.402.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=airlied@redhat.com \
--cc=alexdeucher@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox