public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] [Bluetooth] redo checks in IRQ handler for shared IRQ  support
Date: Tue, 19 Jan 2010 10:21:32 -0800	[thread overview]
Message-ID: <1263925292.5591.169.camel@localhost.localdomain> (raw)
In-Reply-To: <8bd0f97a1001190316k6167ad39h20be3343aba3acb8@mail.gmail.com>

Hi Mike,

> > Commit ac019360fe3 changed the irq handler logic to BUG_ON rather than
> > returning IRQ_NONE when the incoming argument is invalid.  While this
> > works in most cases, it doesn't work when the IRQ is shared with other
> > devices (or when DEBUG_SHIRQ is enabled).
> >
> > So revert the previous change and replace the warning message with a
> > comment explaining that we want this behavior.
> 
> was this picked up ?

not it was not, but now it has been applied to my trees. Thanks.

Regards

Marcel



  reply	other threads:[~2010-01-19 18:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14  5:18 [PATCH] Revert "[Bluetooth] Eliminate checks for impossible conditions in IRQ handler" Mike Frysinger
2009-09-14  9:58 ` Marcel Holtmann
2009-09-14 17:43 ` [PATCH v2] [Bluetooth] redo checks in IRQ handler for shared IRQ support Mike Frysinger
2010-01-19 11:16   ` Mike Frysinger
2010-01-19 18:21     ` Marcel Holtmann [this message]
2009-09-14 23:17 ` [PATCH] Revert "[Bluetooth] Eliminate checks for impossible conditions in IRQ handler" Robert Hancock
2009-09-15 11:28   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263925292.5591.169.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox