From: Peter Zijlstra <peterz@infradead.org>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: fix write_event()
Date: Wed, 20 Jan 2010 15:43:30 +0100 [thread overview]
Message-ID: <1263998610.4283.1076.camel@laptop> (raw)
In-Reply-To: <1263996897.4283.1065.camel@laptop>
On Wed, 2010-01-20 at 15:14 +0100, Peter Zijlstra wrote:
> > > > Uhm, how why? it didn't used to know about events and just copied the
> > > > data.
> > >
> > > looks like acme wrecked it in f5a2c3dc.. anyway the fix is wrong, record
> > > should not know or care about the actual events and simply write data
> > > out.
> >
> > Oh well, I guess then we should do that after record finishes,
> > reprocessing all the data in the file.
>
> Why do we need it at all?
To clarify, we want to keep the record cycle as small/fast as possible
in order to minimize permutation of the system we're recording.
next prev parent reply other threads:[~2010-01-20 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 13:34 [PATCH] perf tools: fix write_event() Xiao Guangrong
2010-01-20 13:41 ` Peter Zijlstra
2010-01-20 13:44 ` Peter Zijlstra
2010-01-20 14:09 ` Arnaldo Carvalho de Melo
2010-01-20 14:14 ` Peter Zijlstra
2010-01-20 14:26 ` Arnaldo Carvalho de Melo
2010-01-20 14:37 ` Peter Zijlstra
2010-01-20 15:43 ` Arnaldo Carvalho de Melo
2010-01-20 14:43 ` Peter Zijlstra [this message]
2010-01-20 15:30 ` Arnaldo Carvalho de Melo
2010-01-20 13:41 ` Frederic Weisbecker
2010-01-31 8:32 ` Ingo Molnar
2010-02-01 8:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263998610.4283.1076.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox