Re: [PATCH 2/2] scsi: add scsi trace core function and put trace points

Kei Tokunaga
2010-02-01T04:46:00Z

Steven Rostedt wrote:
> On Wed, 2010-01-20 at 03:37 -0500, Christoph Hellwig wrote:
>>> --- linux-2.6.33-rc4-trace/kernel/trace/Makefile~scsi_trace 2010-01-18 16:23:16.000000000 +0900
>>> +++ linux-2.6.33-rc4-trace-kei/kernel/trace/Makefile 2010-01-18 16:23:16.000000000 +0900
>>> @@ -48,6 +48,9 @@ obj-$(CONFIG_BLK_DEV_IO_TRACE) += blktra
>>> ifeq ($(CONFIG_BLOCK),y)
>>> obj-$(CONFIG_EVENT_TRACING) += blktrace.o
>>> endif
>>> +ifneq ($(CONFIG_SCSI),)
>>> +obj-$(CONFIG_EVENT_TRACING) += scsitrace.o
>>> +endif
>>> obj-$(CONFIG_EVENT_TRACING) += trace_events.o
>>> obj-$(CONFIG_EVENT_TRACING) += trace_export.o
>>> obj-$(CONFIG_FTRACE_SYSCALLS) += trace_syscalls.o
>> The code should be built into scsi_mod.ko and thus from drivers/scsi/
>>
>
> Yes, none of this code belongs in kernel/trace/.

Thanks for the comments, Christoph, Steven. In v2 patchset that
I'm going to post soon, I've moved the stuff to drivers/scsi/.

Thanks,
Kei