Re: [PATCH 05/36] x86/pci: enable pci root res read out for 32bit too

Yinghai Lu
2010-01-21T20:13:23Z

On 01/21/2010 07:54 AM, Linus Torvalds wrote:
>
>
> On Wed, 20 Jan 2010, Yinghai Lu wrote:
>>
>> printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n",
>> busnum, j,
>> (res->flags & IORESOURCE_IO)?"io port":"mmio",
>> - res->start, res->end);
>> + (u64)res->start, (u64)res->end);
>
> When fixing these kinds of things, please just make it use '%pR' instead.
>
> A simple
>
> printk(KERN_DEBUG "bus: %02x index %x %pR\n", busnum, j, res);
>
> should do the right thing, printing the resource with nice human-readable
> flags. Including things like 64-bit/prefetching information for memory
> resources etc that the current manual resource printout doesn't do.

ok.

YH