public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Christoph Lameter <cl@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 27/36] x86/pci: add mmconf range into e820 for when it is from MSR with amd faml0h
Date: Wed, 20 Jan 2010 22:28:14 -0800	[thread overview]
Message-ID: <1264055303-15123-28-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1264055303-15123-1-git-send-email-yinghai@kernel.org>

for AMD Fam10h, it we read mmconf from MSR early, we should just trust it
because we check it and correct it already.

so add it to e820

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
 arch/x86/kernel/mmconf-fam10h_64.c |   40 ++++++++++++++++++++---------------
 1 files changed, 23 insertions(+), 17 deletions(-)

diff --git a/arch/x86/kernel/mmconf-fam10h_64.c b/arch/x86/kernel/mmconf-fam10h_64.c
index 7182580..645d78a 100644
--- a/arch/x86/kernel/mmconf-fam10h_64.c
+++ b/arch/x86/kernel/mmconf-fam10h_64.c
@@ -16,6 +16,7 @@
 #include <asm/acpi.h>
 #include <asm/mmconfig.h>
 #include <asm/pci_x86.h>
+#include <asm/e820.h>
 
 struct pci_hostbridge_probe {
 	u32 bus;
@@ -27,23 +28,26 @@ struct pci_hostbridge_probe {
 static u64 __cpuinitdata fam10h_pci_mmconf_base;
 static int __cpuinitdata fam10h_pci_mmconf_base_status;
 
+/* only on BSP */
+static void __init_refok e820_add_mmconf_range(int busnbits)
+{
+	u64 end;
+
+	end = fam10h_pci_mmconf_base + (1ULL<<(busnbits + 20)) - 1;
+	if (!e820_all_mapped(fam10h_pci_mmconf_base, end+1, E820_RESERVED)) {
+		printk(KERN_DEBUG "Fam 10h mmconf [%llx, %llx]\n",
+				 fam10h_pci_mmconf_base, end);
+		e820_add_region(fam10h_pci_mmconf_base, 1ULL<<(busnbits + 20),
+				 E820_RESERVED);
+		sanitize_e820_map(e820.map, ARRAY_SIZE(e820.map), &e820.nr_map);
+	}
+}
+
 static struct pci_hostbridge_probe pci_probes[] __cpuinitdata = {
 	{ 0, 0x18, PCI_VENDOR_ID_AMD, 0x1200 },
 	{ 0xff, 0, PCI_VENDOR_ID_AMD, 0x1200 },
 };
 
-static int __cpuinit cmp_range(const void *x1, const void *x2)
-{
-	const struct range *r1 = x1;
-	const struct range *r2 = x2;
-	int start1, start2;
-
-	start1 = r1->start >> 32;
-	start2 = r2->start >> 32;
-
-	return start1 - start2;
-}
-
 /*[47:0] */
 /* need to avoid (0xfd<<32) and (0xfe<<32), ht used space */
 #define FAM10H_PCI_MMCONF_BASE (0xfcULL<<32)
@@ -115,6 +119,7 @@ static void __cpuinit get_fam10h_pci_mmconf_base(void)
 	 * above 4G
 	 */
 	hi_mmio_num = 0;
+	memset(range, 0, sizeof(range));
 	for (i = 0; i < 8; i++) {
 		u32 reg;
 		u64 start;
@@ -130,16 +135,14 @@ static void __cpuinit get_fam10h_pci_mmconf_base(void)
 		if (!end)
 			continue;
 
-		range[hi_mmio_num].start = start;
-		range[hi_mmio_num].end = end;
-		hi_mmio_num++;
+		hi_mmio_num = add_range(range, 8, hi_mmio_num, start, end);
 	}
 
 	if (!hi_mmio_num)
 		goto out;
 
 	/* sort the range */
-	sort(range, hi_mmio_num, sizeof(struct range), cmp_range, NULL);
+	sort_range(range, hi_mmio_num);
 
 	if (range[hi_mmio_num - 1].end < base)
 		goto out;
@@ -169,6 +172,7 @@ fail:
 out:
 	fam10h_pci_mmconf_base = base;
 	fam10h_pci_mmconf_base_status = 1;
+	e820_add_mmconf_range(8);
 }
 
 void __cpuinit fam10h_check_enable_mmcfg(void)
@@ -191,10 +195,12 @@ void __cpuinit fam10h_check_enable_mmcfg(void)
 		/* only trust the one handle 256 buses, if acpi=off */
 		if (!acpi_pci_disabled || busnbits >= 8) {
 			u64 base;
-			base = val & (0xffffULL << 32);
+			base = val & (FAM10H_MMIO_CONF_BASE_MASK <<
+					FAM10H_MMIO_CONF_BASE_SHIFT);
 			if (fam10h_pci_mmconf_base_status <= 0) {
 				fam10h_pci_mmconf_base = base;
 				fam10h_pci_mmconf_base_status = 1;
+				e820_add_mmconf_range(busnbits);
 				return;
 			} else if (fam10h_pci_mmconf_base ==  base)
 				return;
-- 
1.6.4.2


  parent reply	other threads:[~2010-01-21  6:32 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-21  6:27 [PATCH -v4 0/36] x86: not use bootmem for x86 Yinghai Lu
2010-01-21  6:27 ` [PATCH 01/36] x86: move range related operation to one file Yinghai Lu
2010-01-21  6:27 ` [PATCH 02/36] x86: check range in update range Yinghai Lu
2010-01-21 20:43   ` Christoph Lameter
2010-01-21 21:02     ` Yinghai Lu
2010-01-21 21:07       ` Christoph Lameter
2010-01-21  6:27 ` [PATCH 03/36] x86/pci: use u64 instead of size_t in amd_bus.c Yinghai Lu
2010-01-21  6:27 ` [PATCH 04/36] x86/pci: add cap_resource Yinghai Lu
2010-01-21 15:49   ` Linus Torvalds
2010-01-21 20:01     ` Yinghai Lu
2010-01-21  6:27 ` [PATCH 05/36] x86/pci: enable pci root res read out for 32bit too Yinghai Lu
2010-01-21 15:54   ` Linus Torvalds
2010-01-21 20:12     ` Yinghai Lu
2010-01-21  6:27 ` [PATCH 06/36] x86: call early_res_to_bootmem one time Yinghai Lu
2010-01-21  6:27 ` [PATCH 07/36] x86: introduce max_early_res and early_res_count Yinghai Lu
2010-01-21  6:27 ` [PATCH 08/36] x86: dynamic increase early_res array size Yinghai Lu
2010-01-21  6:27 ` [PATCH 09/36] x86: print bootmem free before pci_iommu_alloc and free_all_bootmem -v2 Yinghai Lu
2010-01-21  6:27 ` [PATCH 10/36] x86: make early_node_mem get mem > 4g if possible Yinghai Lu
2010-01-21  6:27 ` [PATCH 11/36] x86: only call dma32_reserve_bootmem 64bit !CONFIG_NUMA Yinghai Lu
2010-01-21  6:27 ` [PATCH 12/36] x86: make 64 bit use early_res instead of bootmem before slab Yinghai Lu
2010-01-21  6:28 ` [PATCH 13/36] sparsemem: put usemap for one node together Yinghai Lu
2010-01-21  6:28 ` [PATCH 14/36] sparsemem: put mem map " Yinghai Lu
2010-01-21  6:28 ` [PATCH 15/36] x86: change range end to start+size Yinghai Lu
2010-01-21  6:28 ` [PATCH 16/36] x86: move bios page reserve early to head32/64.c Yinghai Lu
2010-01-21  6:28 ` [PATCH 17/36] x86: seperate early_res related code from e820.c Yinghai Lu
2010-01-21  6:28 ` [PATCH 18/36] x86: add find_early_area_size Yinghai Lu
2010-01-21  6:28 ` [PATCH 19/36] x86: move back find_e820_area to e820.c Yinghai Lu
2010-01-21  6:28 ` [PATCH 20/36] early_res: enhance check_and_double_early_res Yinghai Lu
2010-01-21  6:28 ` [PATCH 21/36] x86: make 32bit support NO_BOOTMEM Yinghai Lu
2010-01-21  6:28 ` [PATCH 22/36] move round_up/down to kernel.h Yinghai Lu
2010-01-21 20:48   ` Christoph Lameter
2010-01-21 23:14     ` Andi Kleen
2010-01-21  6:28 ` [PATCH 23/36] x86: add find_fw_memmap_area Yinghai Lu
2010-01-21  6:28 ` [PATCH 24/36] core: move early_res Yinghai Lu
2010-01-21  6:28 ` [PATCH 25/36] x86: print out for RAM buffer Yinghai Lu
2010-01-21  6:28 ` [PATCH 26/36] x86: remove bios data range from e820 Yinghai Lu
2010-01-21  6:28 ` Yinghai Lu [this message]
2010-01-21  6:28 ` [PATCH 28/36] irq: remove not need bootmem code Yinghai Lu
2010-01-21  6:28 ` [PATCH 29/36] radix: move radix init early Yinghai Lu
2010-01-21  6:28 ` [PATCH 30/36] sparseirq: change irq_desc_ptrs to static Yinghai Lu
2010-01-21  6:28 ` [PATCH 31/36] sparseirq: use radix_tree instead of ptrs array Yinghai Lu
2010-01-21  6:28 ` [PATCH 32/36] x86: remove arch_probe_nr_irqs Yinghai Lu
2010-01-21  6:28 ` [PATCH 33/36] use nr_cpus= to set nr_cpu_ids early Yinghai Lu
2010-01-21  6:28 ` [PATCH 34/36] x86: according to nr_cpu_ids to decide if need to leave logical flat Yinghai Lu
2010-01-21  6:28 ` [PATCH 35/36] x86: make 32bit apic flat to physflat switch like 64bit Yinghai Lu
2010-01-21  6:28 ` [PATCH 36/36] x86: use num_processors for possible cpus Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264055303-15123-28-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox