From: Mike Galbraith <efault@gmx.de>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf top: losing events?
Date: Thu, 21 Jan 2010 15:56:12 +0100 [thread overview]
Message-ID: <1264085772.5979.3.camel@marge.simson.net> (raw)
In-Reply-To: <20100121144902.GA1244@ghostprotocols.net>
On Thu, 2010-01-21 at 12:49 -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 21, 2010 at 03:28:32PM +0100, Mike Galbraith escreveu:
> > On Thu, 2010-01-21 at 10:22 -0200, Arnaldo Carvalho de Melo wrote:
> >
> > > Can you check if this one helps?
> >
> > Made interrupt count correct, but symbols aren't mapped after the task
> > forks it seems. At least, in event__preprocess_sample(), after
> > thread__find_addr_location(), al->map is NULL a LOT.
>
> Try this one on top of the previous one:
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 8b04988..2227b84 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -975,6 +975,10 @@ static int event__process(event_t *event, struct perf_session *session)
> case PERF_RECORD_MMAP:
> event__process_mmap(event, session);
> break;
> + case PERF_RECORD_FORK:
> + case PERF_RECORD_EXIT:
> + event__process_task(event, session);
> + break;
> default:
> break;
> }
Yup. All better.
I figured that had to to be tied in from rummaging around earlier.
-Mike
next prev parent reply other threads:[~2010-01-21 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 5:42 perf top: losing events? Mike Galbraith
2010-01-21 6:02 ` Mike Galbraith
2010-01-21 12:22 ` Arnaldo Carvalho de Melo
2010-01-21 14:28 ` Mike Galbraith
2010-01-21 14:49 ` Arnaldo Carvalho de Melo
2010-01-21 14:56 ` Mike Galbraith [this message]
2010-01-21 15:02 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264085772.5979.3.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox