public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 07/38] x86/pci: enable pci root res read out for 32bit too
Date: Fri, 22 Jan 2010 01:24:16 -0800	[thread overview]
Message-ID: <1264152287-13866-8-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1264152287-13866-1-git-send-email-yinghai@kernel.org>

should be good for 32bit too.

-v3: cast res->start
-v4: according to Linus, to use %pR instead of cast

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 arch/x86/pci/Makefile    |    3 +--
 arch/x86/pci/amd_bus.c   |   18 ++----------------
 arch/x86/pci/bus_numa.h  |    4 ++--
 arch/x86/pci/i386.c      |    4 ----
 arch/x86/pci/intel_bus.c |    7 ++-----
 5 files changed, 7 insertions(+), 29 deletions(-)

diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
index 564b008..30e55d7 100644
--- a/arch/x86/pci/Makefile
+++ b/arch/x86/pci/Makefile
@@ -14,8 +14,7 @@ obj-$(CONFIG_X86_VISWS)		+= visws.o
 obj-$(CONFIG_X86_NUMAQ)		+= numaq_32.o
 
 obj-y				+= common.o early.o
-obj-y				+= amd_bus.o
-obj-$(CONFIG_X86_64)		+= bus_numa.o intel_bus.o
+obj-y				+= amd_bus.o bus_numa.o intel_bus.o
 
 ifeq ($(CONFIG_PCI_DEBUG),y)
 EXTRA_CFLAGS += -DDEBUG
diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
index 9bcb6fe..badef12 100644
--- a/arch/x86/pci/amd_bus.c
+++ b/arch/x86/pci/amd_bus.c
@@ -6,9 +6,7 @@
 
 #include <asm/pci_x86.h>
 
-#ifdef CONFIG_X86_64
 #include <asm/pci-direct.h>
-#endif
 
 #include "bus_numa.h"
 
@@ -17,8 +15,6 @@
  * also get peer root bus resource for io,mmio
  */
 
-#ifdef CONFIG_X86_64
-
 struct pci_hostbridge_probe {
 	u32 bus;
 	u32 slot;
@@ -339,24 +335,14 @@ static int __init early_fill_mp_bus_info(void)
 		       info->bus_min, info->bus_max, info->node, info->link);
 		for (j = 0; j < res_num; j++) {
 			res = &info->res[j];
-			printk(KERN_DEBUG "bus: %02x index %x %s: [%llx, %llx]\n",
-			       busnum, j,
-			       (res->flags & IORESOURCE_IO)?"io port":"mmio",
-			       res->start, res->end);
+			printk(KERN_DEBUG "bus: %02x index %x %pR\n",
+				       busnum, j, res);
 		}
 	}
 
 	return 0;
 }
 
-#else  /* !CONFIG_X86_64 */
-
-static int __init early_fill_mp_bus_info(void) { return 0; }
-
-#endif /* !CONFIG_X86_64 */
-
-/* common 32/64 bit code */
-
 #define ENABLE_CF8_EXT_CFG      (1ULL << 46)
 
 static void enable_pci_io_ecs(void *unused)
diff --git a/arch/x86/pci/bus_numa.h b/arch/x86/pci/bus_numa.h
index f63e802..08d8e15 100644
--- a/arch/x86/pci/bus_numa.h
+++ b/arch/x86/pci/bus_numa.h
@@ -1,5 +1,5 @@
-#ifdef CONFIG_X86_64
-
+#ifndef __BUS_NUMA_H
+#define __BUS_NUMA_H
 /*
  * sub bus (transparent) will use entres from 3 to store extra from
  * root, so need to make sure we have enough slot there, Should we
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 5dc9e8c..f4e8481 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -257,10 +257,6 @@ void __init pcibios_resource_survey(void)
  */
 fs_initcall(pcibios_assign_resources);
 
-void __weak x86_pci_root_bus_res_quirks(struct pci_bus *b)
-{
-}
-
 /*
  *  If we set up a device for bus mastering, we need to check the latency
  *  timer as certain crappy BIOSes forget to set it properly.
diff --git a/arch/x86/pci/intel_bus.c b/arch/x86/pci/intel_bus.c
index 145e0dd..187f50e 100644
--- a/arch/x86/pci/intel_bus.c
+++ b/arch/x86/pci/intel_bus.c
@@ -26,11 +26,8 @@ static inline void print_ioh_resources(struct pci_root_info *info)
 		struct resource *res;
 
 		res = &info->res[i];
-		printk(KERN_DEBUG "IOH bus: %02x index %x %s: [%llx, %llx]\n",
-			busnum, i,
-			(res->flags & IORESOURCE_IO) ? "io port" :
-							"mmio",
-			res->start, res->end);
+		printk(KERN_DEBUG "IOH bus: %02x index %x %pR\n",
+				busnum, i, res);
 	}
 }
 
-- 
1.6.4.2


  parent reply	other threads:[~2010-01-22  9:37 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22  9:24 [PATCH -v5 0/38] x86: not use bootmem for x86 Yinghai Lu
2010-01-22  9:24 ` [PATCH 01/38] x86: move range related operation to one file Yinghai Lu
2010-01-22  9:24 ` [PATCH 02/38] x86: check range in update range Yinghai Lu
2010-01-22  9:24 ` [PATCH 03/38] x86/pci: use resource_size_t in update_res Yinghai Lu
2010-01-22  9:24 ` [PATCH 04/38] x86/pci: amd one chain system to use pci read out res Yinghai Lu
2010-01-22  9:24 ` [PATCH 05/38] x86/pci: use u64 instead of size_t in amd_bus.c Yinghai Lu
2010-01-22  9:24 ` [PATCH 06/38] x86/pci: add cap_resource Yinghai Lu
2010-01-22  9:24 ` Yinghai Lu [this message]
2010-01-22  9:24 ` [PATCH 08/38] x86: call early_res_to_bootmem one time Yinghai Lu
2010-01-22  9:24 ` [PATCH 09/38] x86: introduce max_early_res and early_res_count Yinghai Lu
2010-01-22  9:24 ` [PATCH 10/38] x86: dynamic increase early_res array size Yinghai Lu
2010-01-22  9:24 ` [PATCH 11/38] x86: print bootmem free before pci_iommu_alloc and free_all_bootmem -v2 Yinghai Lu
2010-01-22  9:24 ` [PATCH 12/38] x86: make early_node_mem get mem > 4g if possible Yinghai Lu
2010-01-22  9:24 ` [PATCH 13/38] x86: only call dma32_reserve_bootmem 64bit !CONFIG_NUMA Yinghai Lu
2010-01-22  9:24 ` [PATCH 14/38] x86: make 64 bit use early_res instead of bootmem before slab Yinghai Lu
2010-01-22  9:24 ` [PATCH 15/38] sparsemem: put usemap for one node together Yinghai Lu
2010-01-22  9:24 ` [PATCH 16/38] sparsemem: put mem map " Yinghai Lu
2010-01-22  9:24 ` [PATCH 17/38] x86: change range end to start+size Yinghai Lu
2010-01-22  9:24 ` [PATCH 18/38] x86: move bios page reserve early to head32/64.c Yinghai Lu
2010-01-22  9:24 ` [PATCH 19/38] x86: seperate early_res related code from e820.c Yinghai Lu
2010-01-22  9:24 ` [PATCH 20/38] x86: add find_early_area_size Yinghai Lu
2010-01-22  9:24 ` [PATCH 21/38] x86: move back find_e820_area to e820.c Yinghai Lu
2010-01-22  9:24 ` [PATCH 22/38] early_res: enhance check_and_double_early_res Yinghai Lu
2010-01-22  9:24 ` [PATCH 23/38] x86: make 32bit support NO_BOOTMEM Yinghai Lu
2010-01-22  9:24 ` [PATCH 24/38] move round_up/down to kernel.h Yinghai Lu
2010-01-22 14:52   ` Christoph Lameter
2010-01-22 19:28     ` Joe Perches
2010-01-22 20:08       ` H. Peter Anvin
2010-01-22  9:24 ` [PATCH 25/38] x86: add find_fw_memmap_area Yinghai Lu
2010-01-22  9:24 ` [PATCH 26/38] core: move early_res Yinghai Lu
2010-01-22  9:24 ` [PATCH 27/38] x86: print out for RAM buffer Yinghai Lu
2010-01-22  9:24 ` [PATCH 28/38] x86: remove bios data range from e820 Yinghai Lu
2010-01-22  9:24 ` [PATCH 29/38] x86/pci: add mmconf range into e820 for when it is from MSR with amd faml0h Yinghai Lu
2010-01-22  9:24 ` [PATCH 30/38] irq: remove not need bootmem code Yinghai Lu
2010-01-22  9:24 ` [PATCH 31/38] radix: move radix init early Yinghai Lu
2010-01-22  9:24 ` [PATCH 32/38] sparseirq: change irq_desc_ptrs to static Yinghai Lu
2010-01-22  9:24 ` [PATCH 33/38] sparseirq: use radix_tree instead of ptrs array Yinghai Lu
2010-01-22  9:24 ` [PATCH 34/38] x86: remove arch_probe_nr_irqs Yinghai Lu
2010-01-22  9:24 ` [PATCH 35/38] use nr_cpus= to set nr_cpu_ids early Yinghai Lu
2010-01-22  9:24 ` [PATCH 36/38] x86: according to nr_cpu_ids to decide if need to leave logical flat Yinghai Lu
2010-01-22  9:24 ` [PATCH 37/38] x86: make 32bit apic flat to physflat switch like 64bit Yinghai Lu
2010-01-22  9:24 ` [PATCH 38/38] x86: use num_processors for possible cpus Yinghai Lu
2010-01-26  0:40 ` [PATCH -v5 0/38] x86: not use bootmem for x86 H. Peter Anvin
2010-01-26  2:14   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264152287-13866-8-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox