[PATCH] get_maintainer.pl: teach git log to use --no-color

[PATCH] get_maintainer.pl: teach git log to use --no-color

[Richard Kennedy]

When git has been set to always use color in .gitconfig then I get the
warning message

    	Bad divisor in main::vcs_assign: 0
    
This is caused by vcs_file_signoffs not matching any commits due to the
pattern not understand the colour codes. Fix this by telling git log to
never use colour.
    
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
----
patch against 2.6.33-rc5
git --version 1.6.6


diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 090f248..2cae27a 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -74,7 +74,7 @@ my %VCS_cmds;
 my %VCS_cmds_git = (
     "execute_cmd" => \&git_execute_cmd,
     "available" => '(which("git") ne "") && (-d ".git")',
-    "find_signers_cmd" => "git log --since=\$email_git_since -- \$file",
+    "find_signers_cmd" => "git log --no-color --since=\$email_git_since -- \$file",
     "find_commit_signers_cmd" => "git log -1 \$commit",
     "blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
     "blame_file_cmd" => "git blame -l \$file",

Re: [PATCH] get_maintainer.pl: teach git log to use --no-color

[Joe Perches]

On Fri, 2010-01-22 at 12:31 +0000, Richard Kennedy wrote:
> When git has been set to always use color in .gitconfig then I get the
> warning message
> 
>     	Bad divisor in main::vcs_assign: 0
>     
> This is caused by vcs_file_signoffs not matching any commits due to the
> pattern not understand the colour codes. Fix this by telling git log to
> never use colour.
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>

Thanks.

Acked-by: Joe Perches <joe@perches.com>

Re: [PATCH] get_maintainer.pl: teach git log to use --no-color

[Joe Perches]

lOn Fri, 2010-01-22 at 12:31 +0000, Richard Kennedy wrote:
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 090f248..2cae27a 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -74,7 +74,7 @@ my %VCS_cmds;
>  my %VCS_cmds_git = (
>      "execute_cmd" => \&git_execute_cmd,
>      "available" => '(which("git") ne "") && (-d ".git")',
> -    "find_signers_cmd" => "git log --since=\$email_git_since -- \$file",
> +    "find_signers_cmd" => "git log --no-color --since=\$email_git_since -- \$file",
>      "find_commit_signers_cmd" => "git log -1 \$commit",
>      "blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
>      "blame_file_cmd" => "git blame -l \$file",

Actually, I take back my ack.

The line immediately below your change also needs --no-color

Can you make that change and resubmit please?

cheers, Joe

Re: [PATCH] get_maintainer.pl: teach git log to use --no-color -- UPDATED

[Richard Kennedy]

When git has been set to always use color in .gitconfig then I get the
warning message

        Bad divisor in main::vcs_assign: 0
    
This is caused by vcs_file_signoffs not matching any commits due to the
pattern not understand the colour codes. Fix this by telling git log to
never use colour.

Updated to fix both calls to 'git log' as requested by Joe Perches
<joe@perches.com>

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>

----
patch against 2.6.33-rc5
git --version 1.6.6

Hi Joe, 
will this do? 

regards
Richard


diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 090f248..2f3230d 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -74,8 +74,8 @@ my %VCS_cmds;
 my %VCS_cmds_git = (
     "execute_cmd" => \&git_execute_cmd,
     "available" => '(which("git") ne "") && (-d ".git")',
-    "find_signers_cmd" => "git log --since=\$email_git_since -- \$file",
-    "find_commit_signers_cmd" => "git log -1 \$commit",
+    "find_signers_cmd" => "git log --no-color --since=\$email_git_since -- \$file",
+    "find_commit_signers_cmd" => "git log --no-color -1 \$commit",
     "blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
     "blame_file_cmd" => "git blame -l \$file",
     "commit_pattern" => "^commit [0-9a-f]{40,40}",

Re: [PATCH] get_maintainer.pl: teach git log to use --no-color -- UPDATED

[Joe Perches]

On Sat, 2010-01-23 at 14:48 +0000, Richard Kennedy wrote:
> Updated to fix both calls to 'git log' as requested by Joe Perches
> <joe@perches.com>
> 
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>

Acked-by: Joe Perches <joe@perches.com>