From: Borislav Petkov <bp@amd64.org>
To: <mingo@elte.hu>, <hpa@zytor.com>, <tglx@linutronix.de>
Cc: <andreas.herrmann3@amd.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>,
Dave Jones <davej@redhat.com>, David Airlie <airlied@linux.ie>
Subject: [PATCH 2/5] intel-agp: Switch to wbinvd_on_all_cpus
Date: Fri, 22 Jan 2010 16:01:04 +0100 [thread overview]
Message-ID: <1264172467-25155-3-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1264172467-25155-1-git-send-email-bp@amd64.org>
From: Borislav Petkov <borislav.petkov@amd.com>
Simplify if-statement while at it.
Cc: Dave Jones <davej@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
drivers/char/agp/intel-agp.c | 14 +++-----------
1 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index 30c36ac..28660b4 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -815,12 +815,6 @@ static void intel_i830_setup_flush(void)
intel_i830_fini_flush();
}
-static void
-do_wbinvd(void *null)
-{
- wbinvd();
-}
-
/* The chipset_flush interface needs to get data that has already been
* flushed out of the CPU all the way out to main memory, because the GPU
* doesn't snoop those buffers.
@@ -837,12 +831,10 @@ static void intel_i830_chipset_flush(struct agp_bridge_data *bridge)
memset(pg, 0, 1024);
- if (cpu_has_clflush) {
+ if (cpu_has_clflush)
clflush_cache_range(pg, 1024);
- } else {
- if (on_each_cpu(do_wbinvd, NULL, 1) != 0)
- printk(KERN_ERR "Timed out waiting for cache flush.\n");
- }
+ else if (wbinvd_on_all_cpus() != 0)
+ printk(KERN_ERR "Timed out waiting for cache flush.\n");
}
/* The intel i830 automatically initializes the agp aperture during POST.
--
1.6.6
next prev parent reply other threads:[~2010-01-22 15:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 15:01 [PATCH -v3 0/5] x86, cacheinfo, amd: L3 Cache Index Disable fixes Borislav Petkov
2010-01-22 15:01 ` [PATCH 1/5] x86, lib: Add wbinvd smp helpers Borislav Petkov
2010-01-23 0:42 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` Borislav Petkov [this message]
2010-01-23 0:42 ` [tip:x86/cpu] intel-agp: Switch to wbinvd_on_all_cpus tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 3/5] x86, cacheinfo: Fix disabling of L3 cache indices Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 4/5] x86, cacheinfo: Add cache index disable sysfs attrs only to L3 caches Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 5/5] x86, cacheinfo: Calculate L3 indices Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 17:24 ` [PATCH -v3 0/5] x86, cacheinfo, amd: L3 Cache Index Disable fixes H. Peter Anvin
2010-01-22 17:40 ` Borislav Petkov
2010-01-22 17:48 ` H. Peter Anvin
2010-01-23 6:59 ` Ingo Molnar
2010-01-23 8:11 ` Borislav Petkov
2010-01-23 9:01 ` Ingo Molnar
2010-01-23 16:32 ` Borislav Petkov
2010-01-25 17:06 ` Borislav Petkov
2010-01-27 12:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264172467-25155-3-git-send-email-bp@amd64.org \
--to=bp@amd64.org \
--cc=airlied@linux.ie \
--cc=andreas.herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox