From: Borislav Petkov <bp@amd64.org>
To: <mingo@elte.hu>, <hpa@zytor.com>, <tglx@linutronix.de>
Cc: <andreas.herrmann3@amd.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH 4/5] x86, cacheinfo: Add cache index disable sysfs attrs only to L3 caches
Date: Fri, 22 Jan 2010 16:01:06 +0100 [thread overview]
Message-ID: <1264172467-25155-5-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1264172467-25155-1-git-send-email-bp@amd64.org>
From: Borislav Petkov <borislav.petkov@amd.com>
The cache_disable_[01] attribute in
/sys/devices/system/cpu/cpu?/cache/index[0-3]/
is enabled on all cache levels although only L3 supports it. Add it only
to the cache level that actually supports it.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/kernel/cpu/intel_cacheinfo.c | 35 ++++++++++++++++++++++++--------
1 files changed, 26 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 08c91ab..3976ce9 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -814,16 +814,24 @@ static struct _cache_attr cache_disable_0 = __ATTR(cache_disable_0, 0644,
static struct _cache_attr cache_disable_1 = __ATTR(cache_disable_1, 0644,
show_cache_disable_1, store_cache_disable_1);
+#define DEFAULT_SYSFS_CACHE_ATTRS \
+ &type.attr, \
+ &level.attr, \
+ &coherency_line_size.attr, \
+ &physical_line_partition.attr, \
+ &ways_of_associativity.attr, \
+ &number_of_sets.attr, \
+ &size.attr, \
+ &shared_cpu_map.attr, \
+ &shared_cpu_list.attr
+
static struct attribute *default_attrs[] = {
- &type.attr,
- &level.attr,
- &coherency_line_size.attr,
- &physical_line_partition.attr,
- &ways_of_associativity.attr,
- &number_of_sets.attr,
- &size.attr,
- &shared_cpu_map.attr,
- &shared_cpu_list.attr,
+ DEFAULT_SYSFS_CACHE_ATTRS,
+ NULL
+};
+
+static struct attribute *default_l3_attrs[] = {
+ DEFAULT_SYSFS_CACHE_ATTRS,
&cache_disable_0.attr,
&cache_disable_1.attr,
NULL
@@ -916,6 +924,7 @@ static int __cpuinit cache_add_dev(struct sys_device * sys_dev)
unsigned int cpu = sys_dev->id;
unsigned long i, j;
struct _index_kobject *this_object;
+ struct _cpuid4_info *this_leaf;
int retval;
retval = cpuid4_cache_sysfs_init(cpu);
@@ -934,6 +943,14 @@ static int __cpuinit cache_add_dev(struct sys_device * sys_dev)
this_object = INDEX_KOBJECT_PTR(cpu, i);
this_object->cpu = cpu;
this_object->index = i;
+
+ this_leaf = CPUID4_INFO_IDX(cpu, i);
+
+ if (this_leaf->can_disable)
+ ktype_cache.default_attrs = default_l3_attrs;
+ else
+ ktype_cache.default_attrs = default_attrs;
+
retval = kobject_init_and_add(&(this_object->kobj),
&ktype_cache,
per_cpu(ici_cache_kobject, cpu),
--
1.6.6
next prev parent reply other threads:[~2010-01-22 15:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 15:01 [PATCH -v3 0/5] x86, cacheinfo, amd: L3 Cache Index Disable fixes Borislav Petkov
2010-01-22 15:01 ` [PATCH 1/5] x86, lib: Add wbinvd smp helpers Borislav Petkov
2010-01-23 0:42 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 2/5] intel-agp: Switch to wbinvd_on_all_cpus Borislav Petkov
2010-01-23 0:42 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 3/5] x86, cacheinfo: Fix disabling of L3 cache indices Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` Borislav Petkov [this message]
2010-01-23 0:43 ` [tip:x86/cpu] x86, cacheinfo: Add cache index disable sysfs attrs only to L3 caches tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 5/5] x86, cacheinfo: Calculate L3 indices Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 17:24 ` [PATCH -v3 0/5] x86, cacheinfo, amd: L3 Cache Index Disable fixes H. Peter Anvin
2010-01-22 17:40 ` Borislav Petkov
2010-01-22 17:48 ` H. Peter Anvin
2010-01-23 6:59 ` Ingo Molnar
2010-01-23 8:11 ` Borislav Petkov
2010-01-23 9:01 ` Ingo Molnar
2010-01-23 16:32 ` Borislav Petkov
2010-01-25 17:06 ` Borislav Petkov
2010-01-27 12:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264172467-25155-5-git-send-email-bp@amd64.org \
--to=bp@amd64.org \
--cc=andreas.herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox