public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/01] regulator: support max8649
Date: Tue, 26 Jan 2010 11:01:41 +0000	[thread overview]
Message-ID: <1264503701.3067.69.camel@odin> (raw)
In-Reply-To: <771cded01001252226k342723b3p3ea235fe79c46843@mail.gmail.com>

On Tue, 2010-01-26 at 01:26 -0500, Haojian Zhuang wrote:
> From 2b5a73c336d2b5dc48c8cf1f2a804b6968659f78 Mon Sep 17 00:00:00 2001
> From: Haojian Zhuang <haojian.zhuang@marvell.com>
> Date: Mon, 25 Jan 2010 10:24:09 -0500
> Subject: [PATCH] regulator: enable max8649 regulator driver
> 
> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>

Can you confirm all the changes compared to the last version. 

> +static int max8649_get_voltage(struct regulator_dev *rdev)
> +{
> +       struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
> +       unsigned char data;
> +       int ret;
> +
> +       ret = max8649_reg_read(info->i2c, info->vol_reg);
> +       if (ret < 0)
> +               return ret;
> +       data = (unsigned char)ret & MAX8649_VOL_MASK;
> +       return (max8649_list_voltage(rdev, data));

Any reason why we have extra () here ?

Thanks

Liam


  reply	other threads:[~2010-01-26 11:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <771cded01001120041ue24edabk8e4638ef7151c947@mail.gmail.com>
     [not found] ` <771cded01001120051l44fd76bx80d2fd4b6f60bd0b@mail.gmail.com>
2010-01-12 11:51   ` [PATCH 01/01] regulator: support max8649 Mark Brown
2010-01-25 11:01     ` Haojian Zhuang
2010-01-25 13:56       ` Mark Brown
2010-01-26  6:26         ` Haojian Zhuang
2010-01-26 11:01           ` Liam Girdwood [this message]
2010-01-26 11:51             ` Haojian Zhuang
2010-01-26 11:04           ` Mark Brown
2010-01-26 11:54             ` Haojian Zhuang
2010-01-26 12:00               ` Mark Brown
2010-01-26 12:14                 ` Haojian Zhuang
2010-01-26 12:41                   ` Mark Brown
2010-01-26 16:10                   ` Liam Girdwood
2010-03-08  6:28                     ` Haojian Zhuang
2010-03-08  8:18                       ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264503701.3067.69.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox