* [PATCH] drm/ttm: remove padding from ttm_ref_object on 64bit builds
@ 2010-01-26 17:10 Richard Kennedy
2010-01-30 15:19 ` Thomas Hellstrom
0 siblings, 1 reply; 2+ messages in thread
From: Richard Kennedy @ 2010-01-26 17:10 UTC (permalink / raw)
To: David Airlie, Thomas Hellstrom; +Cc: lkml, dri-devel
Re-order structure ttm_ref_object to remove 8 bytes of alignment padding
on 64 bit builds, so shrinking its size from 72 to 64 bytes allowing it
to fit into a smaller slab.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
----
patch against 2.6.33-rc5
compiled & tested on x86_64 AMDX2 and nouveau
regards
Richard
diff --git a/drivers/gpu/drm/ttm/ttm_object.c b/drivers/gpu/drm/ttm/ttm_object.c
index 1099aba..75e9d6f 100644
--- a/drivers/gpu/drm/ttm/ttm_object.c
+++ b/drivers/gpu/drm/ttm/ttm_object.c
@@ -109,8 +109,8 @@ struct ttm_ref_object {
struct drm_hash_item hash;
struct list_head head;
struct kref kref;
- struct ttm_base_object *obj;
enum ttm_ref_type ref_type;
+ struct ttm_base_object *obj;
struct ttm_object_file *tfile;
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/ttm: remove padding from ttm_ref_object on 64bit builds
2010-01-26 17:10 [PATCH] drm/ttm: remove padding from ttm_ref_object on 64bit builds Richard Kennedy
@ 2010-01-30 15:19 ` Thomas Hellstrom
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Hellstrom @ 2010-01-30 15:19 UTC (permalink / raw)
To: Richard Kennedy; +Cc: David Airlie, lkml, dri-devel@lists.sourceforge.net
Richard Kennedy wrote:
> Re-order structure ttm_ref_object to remove 8 bytes of alignment padding
> on 64 bit builds, so shrinking its size from 72 to 64 bytes allowing it
> to fit into a smaller slab.
>
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
> ----
> patch against 2.6.33-rc5
> compiled & tested on x86_64 AMDX2 and nouveau
> regards
> Richard
>
>
> diff --git a/drivers/gpu/drm/ttm/ttm_object.c b/drivers/gpu/drm/ttm/ttm_object.c
> index 1099aba..75e9d6f 100644
> --- a/drivers/gpu/drm/ttm/ttm_object.c
> +++ b/drivers/gpu/drm/ttm/ttm_object.c
> @@ -109,8 +109,8 @@ struct ttm_ref_object {
> struct drm_hash_item hash;
> struct list_head head;
> struct kref kref;
> - struct ttm_base_object *obj;
> enum ttm_ref_type ref_type;
> + struct ttm_base_object *obj;
> struct ttm_object_file *tfile;
> };
>
>
>
>
Acked-by: Thomas Hellstrom <thellstrom@vmware.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-30 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-26 17:10 [PATCH] drm/ttm: remove padding from ttm_ref_object on 64bit builds Richard Kennedy
2010-01-30 15:19 ` Thomas Hellstrom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox