From: John Kacur <jkacur@redhat.com>
To: Clark Williams <williams@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Carsten Emde <C.Emde@osadl.org>,
rt-users <linux-rt-users@vger.kernel.org>,
John Kacur <jkacur@redhat.com>
Subject: [PATCH 3/5] rt-tests: Remove the ret variable, the end label and the goto.
Date: Wed, 27 Jan 2010 21:24:26 +0100 [thread overview]
Message-ID: <1264623868-23595-4-git-send-email-jkacur@redhat.com> (raw)
In-Reply-To: <1264623868-23595-1-git-send-email-jkacur@redhat.com>
Remove the ret variable, the end lable and the goto. We already have
inconsistent exit points for the function, and the end lable wasn't strictly
for errors. Directly returning simplifies and shortens the code.
Signed-off-by: John Kacur <jkacur@redhat.com>
---
src/cyclictest/rt_numa.h | 14 +++++---------
1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h
index 8d44097..ac2aca2 100644
--- a/src/cyclictest/rt_numa.h
+++ b/src/cyclictest/rt_numa.h
@@ -73,7 +73,7 @@ static int rt_numa_numa_node_of_cpu(int cpu)
static int rt_numa_numa_node_of_cpu(int cpu)
{
unsigned char cpumask[16];
- int node, ret, idx, bit;
+ int node, idx, bit;
int max_node, max_cpus;
max_node = numa_max_node();
@@ -88,19 +88,15 @@ static int rt_numa_numa_node_of_cpu(int cpu)
idx = cpu / 8;
bit = cpu % 8;
- for (node = 0; node <= max_node; node++){
+ for (node = 0; node <= max_node; node++) {
if (numa_node_to_cpus(node, (void *) cpumask, sizeof(cpumask)))
return -1;
- if (cpumask[idx] & (1<<bit)) {
- ret = node;
- goto end;
- }
+ if (cpumask[idx] & (1<<bit))
+ return node;
}
- ret = -1;
errno = EINVAL;
-end:
- return ret;
+ return -1;
}
#endif /* LIBNUMA_API_VERSION */
--
1.6.6
next prev parent reply other threads:[~2010-01-27 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 20:24 [PATCH 0/5] rt-tests: rt_numa.h clean-ups, and dependency files John Kacur
2010-01-27 20:24 ` [PATCH 1/5] rt-tests: Add header including copyright notice to rt_numa.h John Kacur
2010-01-27 20:24 ` [PATCH 2/5] rt-tests: Separate the #ifdef LIBNUMA_API_VERSION functions John Kacur
2010-01-27 20:24 ` John Kacur [this message]
2010-01-27 20:24 ` [PATCH 4/5] rt-tests: Fix some style problems, such as spaces instead of tabs John Kacur
2010-01-27 20:24 ` [PATCH 5/5] rt-tests: Automatically generate dependencies John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264623868-23595-4-git-send-email-jkacur@redhat.com \
--to=jkacur@redhat.com \
--cc=C.Emde@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).