From: Mike Galbraith <efault@gmx.de>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: john smith <whalajam@yahoo.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: perf report for .ko files
Date: Sat, 30 Jan 2010 07:45:54 +0100 [thread overview]
Message-ID: <1264833954.6097.13.camel@marge.simson.net> (raw)
In-Reply-To: <20100129191558.GA9990@ghostprotocols.net>
On Fri, 2010-01-29 at 17:15 -0200, Arnaldo Carvalho de Melo wrote:
> I actually never tried doing annotation with a module, will try.
Seems it went south again in both .git and .tip. 32 works.
ed52ce2e3c33dc7626a40fa2da766d1a6460e543 is the first bad commit
commit ed52ce2e3c33dc7626a40fa2da766d1a6460e543
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Mon Oct 19 17:17:57 2009 -0200
perf tools: Add ->unmap_ip operation to struct map
We need this because we get section relative addresses when
reading the symtabs, but when a tool like 'perf annotate' needs
to match these address to what 'objdump -dS' produces we need
the address + section back again.
So in annotate now we look at the 'struct hist_entry' instances
(that weren't really being used) so that we iterate only over
the symbols that had some hit and get the map where that
particular hit happened so that we can get the right address to
match with annotate.
Verified that at least:
perf annotate mmap_read_counter # Uses the ~/bin/perf binary
perf annotate --vmlinux /home/acme/git/build/perf/vmlinux intel_pmu_enable_all
on a 'perf record perf top' session seems to work.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1255979877-12533-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
next prev parent reply other threads:[~2010-01-30 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 0:34 perf report for .ko files john smith
2010-01-26 19:21 ` Peter Zijlstra
2010-01-26 21:05 ` Arnaldo Carvalho de Melo
2010-01-29 18:55 ` john smith
2010-01-29 19:15 ` Arnaldo Carvalho de Melo
2010-01-29 21:59 ` john smith
2010-01-30 6:45 ` Mike Galbraith [this message]
2010-02-03 17:28 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264833954.6097.13.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=whalajam@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox