public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	davem@davemloft.net, stable@kernel.org
Subject: Re: patch net-restore-ip-source-validation.patch added to 2.6.32-stable tree
Date: Thu, 04 Feb 2010 14:50:56 -0500	[thread overview]
Message-ID: <1265313056.4651.18.camel@bigi> (raw)
In-Reply-To: <1265308725.4651.14.camel@bigi>

Ok, I was able to reproduce it finally. This fixes it:

---
diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
index b6e7aae..469193c 100644
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -220,6 +220,7 @@ static const struct trans_ctl_table
trans_net_ipv4_conf_vars_table[] = {
        { NET_IPV4_CONF_PROMOTE_SECONDARIES,    "promote_secondaries" },
        { NET_IPV4_CONF_ARP_ACCEPT,             "arp_accept" },
        { NET_IPV4_CONF_ARP_NOTIFY,             "arp_notify" },
+       { NET_IPV4_CONF_SRC_VMARK,              "src_valid_mark" },
        {}
 };
---

Note we dont have that code anymore in current tree - thats why it
was missed...
If this works, Greg/Dave - please include it in the -stable patch.

cheers,
jamal


On Thu, 2010-02-04 at 13:38 -0500, jamal wrote:
> On Thu, 2010-02-04 at 19:31 +0100, Stefan Lippers-Hollmann wrote:
> > Hi
> > 
> > On Thursday 04 February 2010, jamal wrote:
> 
> > > ----
> > >         NET_IPV4_CONF_ARP_ACCEPT=21,
> > >         NET_IPV4_CONF_ARP_NOTIFY=22,
> > >         NET_IPV4_CONF_ACCEPT_LOCAL=23,
> > >         NET_IPV4_CONF_SRC_VMARK=24,
> > >         __NET_IPV4_CONF_MAX
> > > ---
> > > 
> > > I have a feeling you are missing NET_IPV4_CONF_ACCEPT_LOCAL
> > 
> > Yes, you're 100% right - such a hunk is missing from queue-2.6.32 [1]
> > 
> 
> Do you mind changing to NET_IPV4_CONF_SRC_VMARK=23 in that patch?
> As i mentioned in my other email it is a wild guess - so it likely will
> have no effect but worth a try if you have time.
> 
> cheers,
> jamal
> 
> 


  parent reply	other threads:[~2010-02-04 19:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1265060041850@kroah.org>
2010-02-03 20:14 ` patch net-restore-ip-source-validation.patch added to 2.6.32-stable tree Stefan Lippers-Hollmann
2010-02-04 11:13   ` jamal
2010-02-04 17:50     ` Stefan Lippers-Hollmann
2010-02-04 18:14       ` jamal
2010-02-04 18:19         ` David Miller
2010-02-04 18:29           ` jamal
2010-02-04 18:31         ` Stefan Lippers-Hollmann
2010-02-04 18:38           ` jamal
2010-02-04 19:49             ` Stefan Lippers-Hollmann
2010-02-04 19:57               ` jamal
2010-02-04 20:03               ` David Miller
2010-02-04 19:50             ` jamal [this message]
2010-02-04 20:03               ` David Miller
2010-02-05 16:50                 ` Greg KH
2010-02-04 20:24               ` Stefan Lippers-Hollmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265313056.4651.18.camel@bigi \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.L-H@gmx.de \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox