From: Marcel Holtmann <marcel@holtmann.org>
To: Alan Cox <alan@linux.intel.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org, p.hardwick@option.com
Subject: Re: [PATCH 3/3] nozomi: Tidy up the PCI table
Date: Mon, 08 Feb 2010 11:49:49 +0100 [thread overview]
Message-ID: <1265626189.31341.260.camel@localhost.localdomain> (raw)
In-Reply-To: <20100208100710.2794.73323.stgit@localhost.localdomain>
Hi Alan,
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/char/nozomi.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
>
> diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
> index fac9157..86c9e64 100644
> --- a/drivers/char/nozomi.c
> +++ b/drivers/char/nozomi.c
> @@ -136,10 +136,6 @@ static int debug;
> #define RECEIVE_BUF_MAX 4
>
>
> -/* Define all types of vendors and devices to support */
> -#define VENDOR1 0x1931 /* Vendor Option */
> -#define DEVICE1 0x000c /* HSDPA card */
> -
> #define R_IIR 0x0000 /* Interrupt Identity Register */
> #define R_FCR 0x0000 /* Flow Control Register */
> #define R_IER 0x0004 /* Interrupt Enable Register */
> @@ -407,7 +403,7 @@ struct buffer {
>
> /* Global variables */
> static const struct pci_device_id nozomi_pci_tbl[] __devinitconst = {
> - {PCI_DEVICE(VENDOR1, DEVICE1)},
> + {PCI_DEVICE(0x1931, 0x000c)}, /* Nozomi HSPDA */
> {},
that would be HSDPA actually.
Regards
Marcel
next prev parent reply other threads:[~2010-02-08 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 10:06 [PATCH 1/3] nozomi: Add tty_port usage Alan Cox
2010-02-08 10:07 ` [PATCH 2/3] nozomi: Fix mutex handling Alan Cox
2010-02-08 10:07 ` [PATCH 3/3] nozomi: Tidy up the PCI table Alan Cox
2010-02-08 10:49 ` Marcel Holtmann [this message]
2010-02-17 22:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265626189.31341.260.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=alan@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.hardwick@option.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox