[PATCH] fs/ufs: Recognize Solaris-specific file system state

[PATCH] fs/ufs: Recognize Solaris-specific file system state

[Alex Viskovatoff]

Recent releases of Solaris set the fs_clean state of an unmounted UFS file system as FSLOG ("logging fs"). However, the Linux kernel currently does not recognize the value which represents this state. Thus, attempting to mount such a file system rw produces the message

kernel: ufs_read_super: can't grok fs_clean 0xfffffffd

and the file system is mounted read-only. This patch makes the kernel recognize that value.

Signed-off-by: Alex Viskovatoff <viskovatoff@imap.cc>
---
The definitions I used in the patch can be found here:
http://cvs.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/sys/fs/ufs_fs.h

--- linux-2.6.32.7-vanilla/fs/ufs/super.c	2010-01-28 18:06:20.000000000 -0500
+++ linux-2.6/fs/ufs/super.c	2010-02-07 14:56:39.933794932 -0500
@@ -965,6 +965,9 @@ magic_found:
 		case UFS_FSSTABLE:
 			UFSD("fs is stable\n");
 			break;
+		case UFS_FSLOG :
+			UFSD("fs is logging fs\n");
+			break;
 		case UFS_FSOSF1:
 			UFSD("fs is DEC OSF/1\n");
 			break;
diff -uprN -X linux-2.6.32.7-vanilla/Documentation/dontdiff linux-2.6.32.7-vanilla/fs/ufs/ufs_fs.h linux-2.6/fs/ufs/ufs_fs.h
--- linux-2.6.32.7-vanilla/fs/ufs/ufs_fs.h	2010-01-28 18:06:20.000000000 -0500
+++ linux-2.6/fs/ufs/ufs_fs.h	2010-02-08 17:32:49.392619575 -0500
@@ -138,6 +138,7 @@ typedef __u16 __bitwise __fs16;
 
 #define UFS_USEEFT  ((__u16)65535)
 
+/* fs_clean values */
 #define UFS_FSOK      0x7c269d38
 #define UFS_FSACTIVE  ((__s8)0x00)
 #define UFS_FSCLEAN   ((__s8)0x01)
@@ -145,6 +146,11 @@ typedef __u16 __bitwise __fs16;
 #define UFS_FSOSF1    ((__s8)0x03)	/* is this correct for DEC OSF/1? */
 #define UFS_FSBAD     ((__s8)0xff)
 
+/* Solaris-specific fs_clean values */
+#define UFS_FSSUSPEND ((__s8)0xfe)	/* temporarily suspended */
+#define UFS_FSLOG     ((__s8)0xfd)	/* logging fs */
+#define UFS_FSFIX     ((__s8)0xfc)	/* being repaired while mounted */
+
 /* From here to next blank line, s_flags for ufs_sb_info */
 /* directory entry encoding */
 #define UFS_DE_MASK		0x00000010	/* mask for the following */

Re: [PATCH] fs/ufs: Recognize Solaris-specific file system state

[Evgeniy Dushistov]

-----Original Message-----

>Recent releases of Solaris set the fs_clean state of an unmounted UFS file system as FSLOG ("logging fs"). However, the Linux kernel currently does not recognize the value which represents this state. Thus, attempting to mount such a file system rw produces the message
>
>kernel: ufs_read_super: can't grok fs_clean 0xfffffffd
>
>and the file system is mounted read-only. This patch makes the kernel recognize that value.
>

There is some minor style error. Do not forget use scripts/checkpatch.pl.
And may be better will be send copy to Andrew Morton <akpm@linux-foundation.org>,
instead of Linus Torvalds. He will be resend your patch to Linus, during next merge window.

Acked-by: Evgeniy Dushistov  +dushistov@mail.ru