From: Stefani Seibold <stefani@seibold.net>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Theodore Tso <tytso@mit.edu>,
"Ira W. Snyder" <iws@ovro.caltech.edu>
Subject: Re: [PATCH 1/4] fix kfifo miss use of nozami.c
Date: Fri, 12 Feb 2010 08:56:20 +0100 [thread overview]
Message-ID: <1265961380.32651.13.camel@wall-e> (raw)
In-Reply-To: <1265961158.32651.9.camel@wall-e>
User of the kernel fifo should never bypass the API and directly access
the fifo structure. Otherwise it will be very hard to maintain the API.
Signed-off-by: Stefani Seibold <stefani@seibold.net>
---
drivers/char/nozomi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -N -r -p linux-2.6.33-rc7.dummy/drivers/char/nozomi.c linux-2.6.33-rc7.new/drivers/char/nozomi.c
--- linux-2.6.33-rc7.dummy/drivers/char/nozomi.c 2010-02-11 17:05:50.670990421 +0100
+++ linux-2.6.33-rc7.new/drivers/char/nozomi.c 2010-02-11 17:11:20.350865181 +0100
@@ -1743,7 +1743,7 @@ static int ntty_write_room(struct tty_st
if (!port->port.count)
goto exit;
- room = port->fifo_ul.size - kfifo_len(&port->fifo_ul);
+ room = kfifo_avail(&port->fifo_ul);
exit:
mutex_unlock(&port->tty_sem);
next prev parent reply other threads:[~2010-02-12 7:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 7:52 [PATCH 0/4] enhanced reimplemention of the kfifo API Stefani Seibold
2010-02-12 7:56 ` Stefani Seibold [this message]
2010-02-12 7:58 ` [PATCH 2/4] remove the old non generic API Stefani Seibold
2010-02-12 8:03 ` [PATCH 3/4] add the new generic kfifo API Stefani Seibold
2010-02-12 8:07 ` [PATCH 4/4] add example files to the kernel sample directory Stefani Seibold
2010-02-19 9:39 ` Enhanced reimplemention of the kfifo API request for merge Stefani Seibold
-- strict thread matches above, loose matches on Subject: below --
2010-04-18 20:54 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 20:54 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-04-18 21:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 21:05 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-04-20 20:06 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-20 20:06 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-05-12 8:49 really generic, type save and type definable stefani
2010-05-12 8:49 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-07-20 13:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-07-20 13:05 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-08-10 6:40 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-08-10 6:40 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-08-10 8:45 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265961380.32651.13.camel@wall-e \
--to=stefani@seibold.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox