public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* sched: Make the rt throtting disabled tunable valid globally
@ 2010-02-12 16:49 Dhaval Giani
  0 siblings, 0 replies; only message in thread
From: Dhaval Giani @ 2010-02-12 16:49 UTC (permalink / raw)
  To: a.p.zijlstra, mingo; +Cc: linux-kernel


On setting /proc/sys/kernel/sched_rt_runtime_us to -1, the intended
behavior is that rt-group throttling is disabled throughout. This
could be confirmed by trying to launch a real time task in a cgroup
which had zero rt runtime allotted to it.

This though was not happening when one tried to move a rt task into
a rt cgroup which had zero rt runtime. Ensure that this
tunable is honoured globally.

Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>

---
 kernel/sched.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: master/kernel/sched.c
===================================================================
--- master.orig/kernel/sched.c
+++ master/kernel/sched.c
@@ -8542,7 +8542,8 @@ static int sched_rt_global_constraints(v
 int sched_rt_can_attach(struct task_group *tg, struct task_struct *tsk)
 {
 	/* Don't accept realtime tasks when there is no way for them to run */
-	if (rt_task(tsk) && tg->rt_bandwidth.rt_runtime == 0)
+	if (rt_task(tsk) && rt_bandwidth_enabled() &&
+				tg->rt_bandwidth.rt_runtime == 0)
 		return 0;
 
 	return 1;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-12 16:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12 16:49 sched: Make the rt throtting disabled tunable valid globally Dhaval Giani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox