From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>,
stable@kernel.org
Subject: [PATCH 03/10] KVM: SVM: Fix schedule-while-atomic on nested exception handling
Date: Thu, 18 Feb 2010 12:38:28 +0100 [thread overview]
Message-ID: <1266493115-28386-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1266493115-28386-1-git-send-email-joerg.roedel@amd.com>
Move the actual vmexit routine out of code that runs with
irqs and preemption disabled.
Cc: stable@kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kvm/svm.c | 20 +++++++++++++++++---
1 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 7c96b8b..25d26ec 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -128,6 +128,7 @@ static void svm_flush_tlb(struct kvm_vcpu *vcpu);
static void svm_complete_interrupts(struct vcpu_svm *svm);
static int nested_svm_exit_handled(struct vcpu_svm *svm);
+static int nested_svm_exit_handled_atomic(struct vcpu_svm *svm);
static int nested_svm_vmexit(struct vcpu_svm *svm);
static int nested_svm_check_exception(struct vcpu_svm *svm, unsigned nr,
bool has_error_code, u32 error_code);
@@ -1386,7 +1387,7 @@ static int nested_svm_check_exception(struct vcpu_svm *svm, unsigned nr,
svm->vmcb->control.exit_info_1 = error_code;
svm->vmcb->control.exit_info_2 = svm->vcpu.arch.cr2;
- return nested_svm_exit_handled(svm);
+ return nested_svm_exit_handled_atomic(svm);
}
/* This function returns true if it is save to enable the irq window */
@@ -1520,7 +1521,7 @@ static int nested_svm_exit_special(struct vcpu_svm *svm)
/*
* If this function returns true, this #vmexit was already handled
*/
-static int nested_svm_exit_handled(struct vcpu_svm *svm)
+static int __nested_svm_exit_handled(struct vcpu_svm *svm, bool atomic)
{
u32 exit_code = svm->vmcb->control.exit_code;
int vmexit = NESTED_EXIT_HOST;
@@ -1567,12 +1568,25 @@ static int nested_svm_exit_handled(struct vcpu_svm *svm)
}
if (vmexit == NESTED_EXIT_DONE) {
- nested_svm_vmexit(svm);
+ if (!atomic)
+ nested_svm_vmexit(svm);
+ else
+ svm->nested.exit_required = true;
}
return vmexit;
}
+static int nested_svm_exit_handled(struct vcpu_svm *svm)
+{
+ return __nested_svm_exit_handled(svm, false);
+}
+
+static int nested_svm_exit_handled_atomic(struct vcpu_svm *svm)
+{
+ return __nested_svm_exit_handled(svm, true);
+}
+
static inline void copy_vmcb_control_area(struct vmcb *dst_vmcb, struct vmcb *from_vmcb)
{
struct vmcb_control_area *dst = &dst_vmcb->control;
--
1.6.6
next prev parent reply other threads:[~2010-02-18 11:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 11:38 [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Joerg Roedel
2010-02-18 11:38 ` [PATCH 01/10] KVM: SVM: Don't use kmap_atomic in nested_svm_map Joerg Roedel
2010-02-18 13:40 ` Avi Kivity
2010-02-18 16:16 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 02/10] KVM: SVM: Fix wrong interrupt injection in enable_irq_windows Joerg Roedel
2010-02-18 11:38 ` Joerg Roedel [this message]
2010-02-18 13:52 ` [PATCH 03/10] KVM: SVM: Fix schedule-while-atomic on nested exception handling Avi Kivity
2010-02-18 16:24 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 04/10] KVM: SVM: Sync all control registers on nested vmexit Joerg Roedel
2010-02-18 11:38 ` [PATCH 05/10] KVM: SVM: Annotate nested_svm_map with might_sleep() Joerg Roedel
2010-02-18 11:38 ` [PATCH 06/10] KVM: SVM: Fix nested msr intercept handling Joerg Roedel
2010-02-18 11:38 ` [PATCH 07/10] KVM: SVM: Don't sync nested cr8 to lapic and back Joerg Roedel
2010-02-18 11:38 ` [PATCH 08/10] KVM: SVM: Activate nested state only when guest state is complete Joerg Roedel
2010-02-18 11:38 ` [PATCH 09/10] KVM: SVM: Make lazy FPU switching work with nested svm Joerg Roedel
2010-02-18 14:32 ` Avi Kivity
2010-02-18 16:29 ` Joerg Roedel
2010-02-18 14:51 ` Alexander Graf
2010-02-18 14:55 ` Avi Kivity
2010-02-18 16:30 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 10/10] KVM: SVM: Remove newlines from nested trace points Joerg Roedel
2010-02-18 14:33 ` [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Avi Kivity
2010-02-18 14:48 ` Alexander Graf
2010-02-18 14:54 ` Avi Kivity
2010-02-18 16:33 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266493115-28386-4-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox