From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 08/10] KVM: SVM: Activate nested state only when guest state is complete
Date: Thu, 18 Feb 2010 12:38:33 +0100 [thread overview]
Message-ID: <1266493115-28386-9-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1266493115-28386-1-git-send-email-joerg.roedel@amd.com>
Certain functions called during the emulated world switch
behave differently when the vcpu is running nested. This is
not the expected behavior during a world switch emulation.
This patch ensures that the nested state is activated only
if the vcpu is completly in nested state.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kvm/svm.c | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 2a3d525..a64b871 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1631,6 +1631,9 @@ static int nested_svm_vmexit(struct vcpu_svm *svm)
if (!nested_vmcb)
return 1;
+ /* Exit nested SVM mode */
+ svm->nested.vmcb = 0;
+
/* Give the current vmcb to the guest */
disable_gif(svm);
@@ -1718,9 +1721,6 @@ static int nested_svm_vmexit(struct vcpu_svm *svm)
svm->vmcb->save.cpl = 0;
svm->vmcb->control.exit_int_info = 0;
- /* Exit nested SVM mode */
- svm->nested.vmcb = 0;
-
nested_svm_unmap(nested_vmcb);
kvm_mmu_reset_context(&svm->vcpu);
@@ -1753,14 +1753,14 @@ static bool nested_svm_vmrun(struct vcpu_svm *svm)
struct vmcb *nested_vmcb;
struct vmcb *hsave = svm->nested.hsave;
struct vmcb *vmcb = svm->vmcb;
+ u64 vmcb_gpa;
+
+ vmcb_gpa = svm->vmcb->save.rax;
nested_vmcb = nested_svm_map(svm, svm->vmcb->save.rax);
if (!nested_vmcb)
return false;
- /* nested_vmcb is our indicator if nested SVM is activated */
- svm->nested.vmcb = svm->vmcb->save.rax;
-
trace_kvm_nested_vmrun(svm->vmcb->save.rip - 3, svm->nested.vmcb,
nested_vmcb->save.rip,
nested_vmcb->control.int_ctl,
@@ -1875,6 +1875,9 @@ static bool nested_svm_vmrun(struct vcpu_svm *svm)
nested_svm_unmap(nested_vmcb);
+ /* nested_vmcb is our indicator if nested SVM is activated */
+ svm->nested.vmcb = vmcb_gpa;
+
enable_gif(svm);
return true;
--
1.6.6
next prev parent reply other threads:[~2010-02-18 11:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 11:38 [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Joerg Roedel
2010-02-18 11:38 ` [PATCH 01/10] KVM: SVM: Don't use kmap_atomic in nested_svm_map Joerg Roedel
2010-02-18 13:40 ` Avi Kivity
2010-02-18 16:16 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 02/10] KVM: SVM: Fix wrong interrupt injection in enable_irq_windows Joerg Roedel
2010-02-18 11:38 ` [PATCH 03/10] KVM: SVM: Fix schedule-while-atomic on nested exception handling Joerg Roedel
2010-02-18 13:52 ` Avi Kivity
2010-02-18 16:24 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 04/10] KVM: SVM: Sync all control registers on nested vmexit Joerg Roedel
2010-02-18 11:38 ` [PATCH 05/10] KVM: SVM: Annotate nested_svm_map with might_sleep() Joerg Roedel
2010-02-18 11:38 ` [PATCH 06/10] KVM: SVM: Fix nested msr intercept handling Joerg Roedel
2010-02-18 11:38 ` [PATCH 07/10] KVM: SVM: Don't sync nested cr8 to lapic and back Joerg Roedel
2010-02-18 11:38 ` Joerg Roedel [this message]
2010-02-18 11:38 ` [PATCH 09/10] KVM: SVM: Make lazy FPU switching work with nested svm Joerg Roedel
2010-02-18 14:32 ` Avi Kivity
2010-02-18 16:29 ` Joerg Roedel
2010-02-18 14:51 ` Alexander Graf
2010-02-18 14:55 ` Avi Kivity
2010-02-18 16:30 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 10/10] KVM: SVM: Remove newlines from nested trace points Joerg Roedel
2010-02-18 14:33 ` [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Avi Kivity
2010-02-18 14:48 ` Alexander Graf
2010-02-18 14:54 ` Avi Kivity
2010-02-18 16:33 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266493115-28386-9-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox