From: john stultz <johnstul@us.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: printk_ratelimited() not compiling
Date: Thu, 18 Feb 2010 14:10:13 -0800 [thread overview]
Message-ID: <1266531013.3201.86.camel@localhost.localdomain> (raw)
Hey Joe,
So I thought printk_ratelimited would be perfect for an issue I'm
having, but when I tried using it, replacing a printk I had, I got the
following:
fs/namei.c:1075: error: variable ‘_rs’ has initializer but incomplete type
fs/namei.c:1075: error: unknown field ‘interval’ specified in initializer
fs/namei.c:1075: warning: excess elements in struct initializer
fs/namei.c:1075: warning: (near initialization for ‘_rs’)
fs/namei.c:1075: error: unknown field ‘burst’ specified in initializer
fs/namei.c:1075: warning: excess elements in struct initializer
fs/namei.c:1075: warning: (near initialization for ‘_rs’)
fs/namei.c:1075: error: storage size of ‘_rs’ isn’t known
fs/namei.c:1075: warning: unused variable ‘_rs’
Thinking the issue was ratelimit.h wasn't included I tried that, but
got:
file included from include/linux/spinlock_types.h:18,
from include/linux/ratelimit.h:5,
from include/linux/kernel.h:21,
from /home/jstultz/projects/linux/linux-2.6-git/arch/x86/include/asm/percpu.h:45,
from /home/jstultz/projects/linux/linux-2.6-git/arch/x86/include/asm/current.h:5,
from /home/jstultz/projects/linux/linux-2.6-git/arch/x86/include/asm/processor.h:15,
from include/linux/prefetch.h:14,
from include/linux/list.h:6,
from include/linux/module.h:9,
from include/linux/crypto.h:21,
from arch/x86/kernel/asm-offsets_64.c:8,
from arch/x86/kernel/asm-offsets.c:4:
include/linux/lockdep.h:52: error: field ‘hash_entry’ has incomplete type
include/linux/lockdep.h:57: error: field ‘lock_entry’ has incomplete type
include/linux/lockdep.h:74: error: field ‘locks_after’ has incomplete type
include/linux/lockdep.h:74: error: field ‘locks_before’ has incomplete type
include/linux/lockdep.h:148: error: field ‘entry’ has incomplete type
include/linux/lockdep.h:167: error: field ‘entry’ has incomplete type
make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2
Yuck.
Am I missing something obvious, or did something get broken after this went in?
thanks
-john
next reply other threads:[~2010-02-18 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 22:10 john stultz [this message]
2010-02-18 22:28 ` printk_ratelimited() not compiling Joe Perches
2010-02-18 22:36 ` john stultz
2010-02-18 23:23 ` Joe Perches
2010-02-18 23:33 ` john stultz
2010-02-18 23:49 ` john stultz
2010-02-19 0:15 ` [RFC PATCH] printk_ratelimited: Move definitions to ratelimit.h, use DEFINE_RATELIMIT_STATE Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266531013.3201.86.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox