From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: [PATCH 4/5] perf: Remove pointless breakpoint union
Date: Sat, 27 Feb 2010 19:25:32 +0100 [thread overview]
Message-ID: <1267295133-6320-5-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1267295133-6320-1-git-send-regression-fweisbec@gmail.com>
Remove pointless union in the breakpoint field of hw_perf_event.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
---
include/linux/perf_event.h | 5 ++---
lib/Kconfig.debug | 8 +++++---
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 7b18b4f..04f06b4 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -487,9 +487,8 @@ struct hw_perf_event {
struct hrtimer hrtimer;
};
#ifdef CONFIG_HAVE_HW_BREAKPOINT
- union { /* breakpoint */
- struct arch_hw_breakpoint info;
- };
+ /* breakpoint */
+ struct arch_hw_breakpoint info;
#endif
};
atomic64_t prev_count;
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 65f964e..4dc24cc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -520,11 +520,13 @@ config LOCK_STAT
For more details, see Documentation/lockstat.txt
- You can analyze lock events with "perf lock", subcommand of perf.
- If you want to use "perf lock", you need to turn on CONFIG_EVENT_TRACING.
+ This also enables lock events required by "perf lock",
+ subcommand of perf.
+ If you want to use "perf lock", you also need to turn on
+ CONFIG_EVENT_TRACING.
CONFIG_LOCK_STAT defines "contended" and "acquired" lock events.
- (CONFIG_LOCKDEP defines "acquire" and "release" events.)
+ (CONFIG_LOCKDEP defines "acquire" and "release" events.)
config DEBUG_LOCKDEP
bool "Lock dependency engine debugging"
--
1.6.2.3
next prev parent reply other threads:[~2010-02-27 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 18:25 [GIT PULL] Perf updates Frederic Weisbecker
2010-02-27 18:25 ` [PATCH 1/5] percpu: Add __percpu sparse annotations to hw_breakpoint Frederic Weisbecker
2010-02-27 18:25 ` [PATCH 2/5] perf lock: Fix and add misc documentally things Frederic Weisbecker
2010-02-27 18:25 ` [PATCH 3/5] perf lock: Drop the buffers multiplexing dependency Frederic Weisbecker
2010-02-27 18:25 ` Frederic Weisbecker [this message]
2010-02-27 18:25 ` [PATCH 5/5] x86/hw-breakpoints: Remove the name field Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267295133-6320-5-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).