From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551Ab0CEThr (ORCPT ); Fri, 5 Mar 2010 14:37:47 -0500 Received: from casper.infradead.org ([85.118.1.10]:35298 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754833Ab0CEThq (ORCPT ); Fri, 5 Mar 2010 14:37:46 -0500 Subject: Re: [PATCH 3/5] perf, x86: Disable PEBS on clowertown chips From: Peter Zijlstra To: Stephane Eranian Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, paulus@samba.org, robert.richter@amd.com, fweisbec@gmail.com, Arnaldo Carvalho de Melo In-Reply-To: References: <20100305153926.639506880@chello.nl> <20100305154128.890278662@chello.nl> <1267816553.4942.6.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Mar 2010 20:37:42 +0100 Message-ID: <1267817862.4942.7.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-03-05 at 11:28 -0800, Stephane Eranian wrote: > On Fri, Mar 5, 2010 at 11:15 AM, Peter Zijlstra wrote: > > On Fri, 2010-03-05 at 10:58 -0800, Stephane Eranian wrote: > >> > case 15: /* original 65 nm celeron/pentium/core2/xeon, "Merom"/"Conroe" */ > >> > + x86_pmu.quirks = intel_clowertown_quirks; > >> > >> That's too coarse grain! > >> It is more subtle than this. Some of the errata are marked as Plan > >> fix. They seem to be > >> fixed in later models. Your looking at the E5xxx series errata but the > >> E7xxx do not have > >> the same problems. > > > > OK, I'll look at those errata again and try to come up with a stepping > > test for this errata. > > > There is erratum which you need to implement the workaround for and > this is AAJ91 on Nehalem. It does happen. Yes, I found that one too today. Its on my todo list.