From: Richard Kennedy <richard@rsk.demon.co.uk>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: block: blk-timeout.c possible mishandling of jiffies wrap?
Date: Sun, 07 Mar 2010 17:47:44 +0000 [thread overview]
Message-ID: <1267984064.2115.50.camel@localhost> (raw)
Hi Jens,
In blk_rq_timed_out_timer() in blk-timeout.c the comment at line 129
says that the request deadline can never be zero as that gets fixed in
blk_add_timer.
However commit 7838c15b8dd18e78a523513749e5b54bda07b0cb
removed the line that bumped deadline if zero.
So now AFAICT there's nothing to prevent deadline being zero, and
blk_rq_timed_out_timer may not always do the right thing when jiffies is
about to wrap.
There was a next_set flag in blk_rq_timed_out_timer but that's been
removed too.
Do you have any preferred fix? A next_set flag or a deadline bump or
something else?
regards
Richard
reply other threads:[~2010-03-07 17:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267984064.2115.50.camel@localhost \
--to=richard@rsk.demon.co.uk \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox