From: Johannes Berg <johannes@sipsolutions.net>
To: Vadim Zaliva <lord@crocodile.org>
Cc: linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver
Date: Mon, 08 Mar 2010 08:41:57 +0100 [thread overview]
Message-ID: <1268034117.3819.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <E64899AA-23A5-49D7-8C91-B94A095290E0@crocodile.org>
On Fri, 2010-03-05 at 11:47 -0800, Vadim Zaliva wrote:
> This small patch is fixing an integer overflow issue in 'appletouch' driver.
>
> In particular, reading data from Geyser 2 touchpads used on post Oct
> 2005 Apple PowerBooks the driver was casting X and Y coordinates
> values to 'signed char'. Testing on one of such PowerBooks I have
> noticed that touchpad always generates positive values, but some of
> them are greater that 127, and thus, when cast to 'signed char' being
> interpreted as a negative.
>
> Such bigger values have been observed infrequently, closer to the
> edges of a touchpad, so the problem was not very visible.
> Nevertheless, the patch would potentially improve touchpad
> driver accuracy.
Hmm, you're probably right, and I cannot test with my powerbook as I'm
about to leave on travel and it's at my parents.
johannes
next prev parent reply other threads:[~2010-03-08 7:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 19:47 [PATCH 1/1] integer overflow issue in 'appletouch' driver Vadim Zaliva
2010-03-08 7:41 ` Johannes Berg [this message]
2010-03-09 19:43 ` Vadim Zaliva
2010-03-10 6:22 ` Dmitry Torokhov
2010-08-07 14:00 ` Serge Belyshev
2010-08-07 15:47 ` Johannes Berg
2010-08-09 0:20 ` Benjamin Herrenschmidt
2010-08-09 1:24 ` Vadim Zaliva
2010-08-09 3:43 ` Benjamin Herrenschmidt
2010-08-09 16:33 ` Dmitry Torokhov
2010-08-09 22:36 ` Benjamin Herrenschmidt
2018-06-20 0:24 ` Dmitry Torokhov
2010-03-10 17:37 ` Vadim Zaliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268034117.3819.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@crocodile.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).