From: Chihau Chau <chihau@gmail.com>
To: jmorris@namei.org
Cc: dhowells@redhat.com, paulmck@linux.vnet.ibm.com, mingo@elte.hu,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Chihau Chau <chihau@gmail.com>
Subject: [PATCH] Security: key: keyring: fix code style issues
Date: Tue, 9 Mar 2010 16:03:48 -0300 [thread overview]
Message-ID: <1268161428-32317-1-git-send-email-chihau@gmail.com> (raw)
From: Chihau Chau <chihau@gmail.com>
This fixes to include <linux/uaccess.h> instead <asm/uaccess.h> and some
code style issues like to put a else sentence below close brace '}' and
to replace a tab instead of some space characters.
Signed-off-by: Chihau Chau <chihau@gmail.com>
---
security/keys/keyring.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/security/keys/keyring.c b/security/keys/keyring.c
index e814d21..d8b5d5e 100644
--- a/security/keys/keyring.c
+++ b/security/keys/keyring.c
@@ -17,7 +17,7 @@
#include <linux/seq_file.h>
#include <linux/err.h>
#include <keys/keyring-type.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
#include "internal.h"
/*
@@ -172,8 +172,7 @@ static void keyring_describe(const struct key *keyring, struct seq_file *m)
if (keyring->description) {
seq_puts(m, keyring->description);
- }
- else {
+ } else {
seq_puts(m, "[anon]");
}
@@ -306,7 +305,7 @@ key_ref_t keyring_search_aux(key_ref_t keyring_ref,
key_check(keyring);
/* top keyring must have search permission to begin the search */
- err = key_task_permission(keyring_ref, cred, KEY_SEARCH);
+ err = key_task_permission(keyring_ref, cred, KEY_SEARCH);
if (err < 0) {
key_ref = ERR_PTR(err);
goto error;
@@ -775,8 +774,7 @@ int __key_link(struct key *keyring, struct key *key)
smp_wmb();
klist->nkeys++;
smp_wmb();
- }
- else {
+ } else {
/* grow the key list */
max = 4;
if (klist)
--
1.5.6.3
next reply other threads:[~2010-03-09 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 19:03 Chihau Chau [this message]
[not found] <emcYy-av-15@gated-at.bofh.it>
2010-03-09 19:16 ` [PATCH] Security: key: keyring: fix code style issues James Kosin
[not found] <elPIC-7L6-15@gated-at.bofh.it>
2010-03-08 19:15 ` James Kosin
[not found] ` <f5ca57691003081211g2dab077cv323138699ccd03b3@mail.gmail.com>
2010-03-08 21:33 ` James Kosin
2010-03-08 23:03 ` Chihau Chau
-- strict thread matches above, loose matches on Subject: below --
2010-03-08 18:14 Chihau Chau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268161428-32317-1-git-send-email-chihau@gmail.com \
--to=chihau@gmail.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).