From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, Greg KH <gregkh@suse.de>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Loongson-2F: Flush the branch target history such as BTB and RAS
Date: Wed, 10 Mar 2010 23:24:04 +0800 [thread overview]
Message-ID: <1268234645.19976.1.camel@falcon> (raw)
In-Reply-To: <4B977815.4000703@ru.mvista.com>
Hi,
Thanks very much for your careful review, will resend a new one later.
Regards,
Wu Zhangjin
On Wed, 2010-03-10 at 13:44 +0300, Sergei Shtylyov wrote:
[...]
> > diff --git a/arch/mips/include/asm/stackframe.h b/arch/mips/include/asm/stackframe.h
> > index 3b6da33..b84cfda 100644
> > --- a/arch/mips/include/asm/stackframe.h
> > +++ b/arch/mips/include/asm/stackframe.h
> > @@ -121,6 +121,25 @@
> > .endm
> > #else
> > .macro get_saved_sp /* Uniprocessor variation */
> > +#ifdef CONFIG_CPU_LOONGSON2F
> > + /*
> > + * Clear BTB(branch target buffer), forbid RAS(row address
> > + * strobe)
>
> No spaces before the left paren...
>
> > to workaround the Out-of-oder Issue in Loongson2F
> > + * via it's diagnostic register.
> >
>
> Only "its".
>
> > + */
> > + move k0, ra
> >
>
> Operands misalined...
>
> WBR, Sergei
>
>
next prev parent reply other threads:[~2010-03-10 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 17:12 [PATCH 0/3] Workaround the Out-of-order Issue of Loongson-2F Wu Zhangjin
2010-03-09 17:12 ` [PATCH 1/3] Loongson-2F: Flush the branch target history such as BTB and RAS Wu Zhangjin
2010-03-10 10:44 ` Sergei Shtylyov
2010-03-10 15:24 ` Wu Zhangjin [this message]
2010-03-11 3:27 ` Shinya Kuribayashi
2010-03-11 3:35 ` Wu Zhangjin
2010-03-11 9:59 ` Ralf Baechle
2010-03-13 3:52 ` Wu Zhangjin
2010-03-14 23:42 ` Shinya Kuribayashi
2010-03-09 17:12 ` [PATCH 2/3] Loongson-2F: Enable fixups of binutils 2.20.1 Wu Zhangjin
2010-03-09 17:12 ` [PATCH 3/3] Loongson-2F: Fixup of problems introduced by -mfix-loongson2f-jump " Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268234645.19976.1.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).