public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] =?UTF-8?q?Staging:=20batman-adv:=20Fix=20coding=20style=20in=20device.c
@ 2010-03-10 22:09 Ólafur Jens Sigurðsson
  2010-04-27 20:34 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Ólafur Jens Sigurðsson @ 2010-03-10 22:09 UTC (permalink / raw)
  To: gregkh, andrew, lindner_marek, siwu, sdietrich
  Cc: devel, linux-kernel, Ólafur Jens Śigurðsson

From: Ólafur Jens Śigurðsson <ojsbug@gmail.com>

---
 drivers/staging/batman-adv/device.c |   15 ++++++++++-----
 1 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/batman-adv/device.c b/drivers/staging/batman-adv/device.c
index e7f4421..6edc2f2 100644
--- a/drivers/staging/batman-adv/device.c
+++ b/drivers/staging/batman-adv/device.c
@@ -67,7 +67,7 @@ int bat_device_setup(void)
 	batman_class = class_create(THIS_MODULE, "batman-adv");
 
 	if (IS_ERR(batman_class)) {
-		printk(KERN_ERR "batman-adv:Could not register class 'batman-adv' \n");
+		printk(KERN_ERR "batman-adv:Could not register class 'batman-adv'\n");
 		return 0;
 	}
 
@@ -110,7 +110,7 @@ int bat_device_open(struct inode *inode, struct file *file)
 	}
 
 	if (device_client_hash[i] != device_client) {
-		printk(KERN_ERR "batman-adv:Error - can't add another packet client: maximum number of clients reached \n");
+		printk(KERN_ERR "batman-adv:Error - can't add another packet client: maximum number of clients reached\n");
 		kfree(device_client);
 		return -EXFULL;
 	}
@@ -211,7 +211,8 @@ ssize_t bat_device_write(struct file *file, const char __user *buff,
 	unsigned long flags;
 
 	if (len < sizeof(struct icmp_packet)) {
-		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: invalid packet size\n");
+		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from "
+					"char device: invalid packet size\n");
 		return -EINVAL;
 	}
 
@@ -222,12 +223,16 @@ ssize_t bat_device_write(struct file *file, const char __user *buff,
 		return -EFAULT;
 
 	if (icmp_packet.packet_type != BAT_ICMP) {
-		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: got bogus packet type (expected: BAT_ICMP)\n");
+		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from "
+					"char device: got bogus packet type "
+					"(expected: BAT_ICMP)\n");
 		return -EINVAL;
 	}
 
 	if (icmp_packet.msg_type != ECHO_REQUEST) {
-		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: got bogus message type (expected: ECHO_REQUEST)\n");
+		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from "
+					"char device: got bogus message type "
+					"(expected: ECHO_REQUEST)\n");
 		return -EINVAL;
 	}
 
-- 
1.6.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] =?UTF-8?q?Staging:=20batman-adv:=20Fix=20coding=20style=20in=20device.c
  2010-03-10 22:09 [PATCH] =?UTF-8?q?Staging:=20batman-adv:=20Fix=20coding=20style=20in=20device.c Ólafur Jens Sigurðsson
@ 2010-04-27 20:34 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-04-27 20:34 UTC (permalink / raw)
  To: Ólafur Jens Sigurðsson
  Cc: gregkh, andrew, lindner_marek, siwu, sdietrich, devel,
	linux-kernel

On Wed, Mar 10, 2010 at 10:09:35PM +0000, Ólafur Jens Sigurðsson wrote:
> From: Ólafur Jens Śigurðsson <ojsbug@gmail.com>

I need a "Signed-off-by" line in order to be able to apply this.  Care
to resend it with that?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-27 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-10 22:09 [PATCH] =?UTF-8?q?Staging:=20batman-adv:=20Fix=20coding=20style=20in=20device.c Ólafur Jens Sigurðsson
2010-04-27 20:34 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox