From: ehames@gmail.com
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, Edgardo Hames <ehames@gmail.com>
Subject: [PATCH 2/2] Staging: wlan-ng: rework after feedback
Date: Mon, 15 Mar 2010 23:00:40 -0300 [thread overview]
Message-ID: <1268704840-7166-2-git-send-email-ehames@gmail.com> (raw)
In-Reply-To: <1268704840-7166-1-git-send-email-ehames@gmail.com>
From: Edgardo Hames <ehames@gmail.com>
This patch includes the feedback received from Richard Kennedy.
Signed-off-by: Edgardo Hames <ehames@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 19 ++++++++-----------
1 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 2400242..a41db5d 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -2612,19 +2612,18 @@ int hfa384x_drvr_start(hfa384x_t *hw)
if (result1 != 0) {
if (result2 != 0) {
printk(KERN_ERR
- "cmd_initialize() failed on two attempts,"
- " results %d and %d\n", result1, result2);
+ "cmd_initialize() failed on two attempts, results %d and %d\n",
+ result1, result2);
usb_kill_urb(&hw->rx_urb);
goto done;
} else {
pr_debug("First cmd_initialize() failed (result %d),\n",
result1);
- pr_debug("but second attempt succeeded."
- " All should be ok\n");
+ pr_debug("but second attempt succeeded. All should be ok\n");
}
} else if (result2 != 0) {
- printk(KERN_WARNING "First cmd_initialize() succeeded,"
- " but second attempt failed (result=%d)\n", result2);
+ printk(KERN_WARNING "First cmd_initialize() succeeded, but second attempt failed (result=%d)\n",
+ result2);
printk(KERN_WARNING
"Most likely the card will be functional\n");
goto done;
@@ -3382,9 +3381,7 @@ retry:
* our request has been acknowledged. Odd,
* but our OUT URB is still alive...
*/
- pr_debug("Causality violation: "
- "please reboot Universe, or email "
- "linux-wlan-devel@lists.linux-wlan.com\n");
+ pr_debug("Causality violation: please reboot Universe\n");
ctlx->state = CTLX_RESP_COMPLETE;
break;
@@ -3848,8 +3845,8 @@ retry:
default:
/* This is NOT a valid CTLX "success" state! */
- printk(KERN_ERR "Illegal CTLX[%d]"
- " success state(%s, %d) in OUT URB\n",
+ printk(KERN_ERR
+ "Illegal CTLX[%d] success state(%s, %d) in OUT URB\n",
le16_to_cpu(ctlx->outbuf.type),
ctlxstr(ctlx->state), urb->status);
break;
--
1.6.3.3
prev parent reply other threads:[~2010-03-16 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 2:00 [PATCH 1/2] Staging: wlan-ng: fix coding style in hfa834x_usb.c ehames
2010-03-16 2:00 ` ehames [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268704840-7166-2-git-send-email-ehames@gmail.com \
--to=ehames@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox