From: Steven Rostedt <rostedt@goodmis.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, robert.richter@amd.com
Subject: Re: [PATCH] oprofile: remove double ring buffering
Date: Sat, 20 Mar 2010 00:45:20 -0400 [thread overview]
Message-ID: <1269060320.28658.7.camel@localhost> (raw)
In-Reply-To: <20100320000323.GA8411@basil.fritz.box>
On Sat, 2010-03-20 at 01:03 +0100, Andi Kleen wrote:
> [This is currently being tested if it fixes the excessive samples
> dropping I have been complaining about for some time. Still wanted
> to post the patch for review.]
>
> commit 49e66e8ab54f1114237e6dc24dc32ac912870c41
> Author: Andi Kleen <ak@linux.intel.com>
> Date: Fri Mar 19 21:03:48 2010 +0100
>
> oprofile: remove double ring buffering
>
> oprofile used a double buffer scheme for its cpu event buffer
> to avoid races on reading with the old lock less ring buffer.
The old ring buffer was not lockless, hence the need for two ring
buffers because of NMIs. The new ring buffer is lockless.
>
> But that is obsolete now with the new ring buffer, so simply
> use a single buffer. This greatly simplifies the code and avoids
> some situations where samples could be dropped.
>
> Based on suggestions from Steven Rostedt
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
next prev parent reply other threads:[~2010-03-20 4:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 0:03 [PATCH] oprofile: remove double ring buffering Andi Kleen
2010-03-20 4:45 ` Steven Rostedt [this message]
2010-03-20 4:59 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2010-04-01 1:17 Andi Kleen
2010-04-01 19:02 ` Robert Richter
2010-04-01 19:11 ` Steven Rostedt
2010-04-04 10:01 ` Andi Kleen
2010-04-04 13:07 ` Steven Rostedt
2010-04-22 14:33 ` John Villalovos
2010-04-22 23:04 ` Andrew Morton
2010-04-23 9:00 ` Robert Richter
2010-04-23 15:38 ` Robert Richter
2010-04-23 15:38 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269060320.28658.7.camel@localhost \
--to=rostedt@goodmis.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).