linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giel van Schijndel <me@mortis.eu>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	Giel van Schijndel <me@mortis.eu>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	Laurens Leemans <laurens@signips.com>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] hwmon: f71882fg: prepare for addition of watchdog support
Date: Wed, 24 Mar 2010 00:12:14 +0100	[thread overview]
Message-ID: <1269385936-3440-2-git-send-email-me@mortis.eu> (raw)
In-Reply-To: <1269385936-3440-1-git-send-email-me@mortis.eu>

Rename the `address' variable that's used in some places to hwmon_addr
to indicate it refers to the hardware monitor (HWMON in datasheet)
"logical device" of the chip.

Signed-off-by: Giel van Schijndel <me@mortis.eu>
---
 drivers/hwmon/f71882fg.c |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
index b290b87..7b31e14 100644
--- a/drivers/hwmon/f71882fg.c
+++ b/drivers/hwmon/f71882fg.c
@@ -2233,7 +2233,7 @@ static int f71882fg_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static int __init f71882fg_find(int sioaddr, unsigned short *address,
+static int __init f71882fg_find(int sioaddr, unsigned short *hwmon_addr,
 	struct f71882fg_sio_data *sio_data)
 {
 	int err = -ENODEV;
@@ -2290,16 +2290,16 @@ static int __init f71882fg_find(int sioaddr, unsigned short *address,
 		goto exit;
 	}
 
-	*address = superio_inw(sioaddr, SIO_REG_ADDR);
-	if (*address == 0) {
+	*hwmon_addr = superio_inw(sioaddr, SIO_REG_ADDR);
+	if (*hwmon_addr == 0) {
 		printk(KERN_WARNING DRVNAME ": Base address not set\n");
 		goto exit;
 	}
-	*address &= ~(REGION_LENGTH - 1);	/* Ignore 3 LSB */
+	*hwmon_addr &= ~(REGION_LENGTH - 1);	/* Ignore 3 LSB */
 
 	err = 0;
 	printk(KERN_INFO DRVNAME ": Found %s chip at %#x, revision %d\n",
-		f71882fg_names[sio_data->type],	(unsigned int)*address,
+		f71882fg_names[sio_data->type],	(unsigned int)*hwmon_addr,
 		(int)superio_inb(sioaddr, SIO_REG_DEVREV));
 exit:
 	superio_exit(sioaddr);
@@ -2307,17 +2307,17 @@ exit:
 	return err;
 }
 
-static int __init f71882fg_device_add(unsigned short address,
+static int __init f71882fg_device_add(unsigned short hwmon_addr,
 	const struct f71882fg_sio_data *sio_data)
 {
 	struct resource res = {
-		.start	= address,
-		.end	= address + REGION_LENGTH - 1,
+		.start	= hwmon_addr,
+		.end	= hwmon_addr + REGION_LENGTH - 1,
 		.flags	= IORESOURCE_IO,
 	};
 	int err;
 
-	f71882fg_pdev = platform_device_alloc(DRVNAME, address);
+	f71882fg_pdev = platform_device_alloc(DRVNAME, hwmon_addr);
 	if (!f71882fg_pdev)
 		return -ENOMEM;
 
@@ -2357,14 +2357,14 @@ static int __init f71882fg_init(void)
 {
 	static const unsigned short addrs[] = { 0x2e, 0x4e };
 	int err = -ENODEV;
-	unsigned short address = /* shut up compiler */ 0;
+	unsigned short hwmon_addr = /* shut up compiler */ 0;
 	struct f71882fg_sio_data sio_data;
 	int i;
 
 	memset(&sio_data, 0, sizeof(sio_data));
 
 	for (i = 0; i < ARRAY_SIZE(addrs); i++) {
-		err = f71882fg_find(addrs[i], &address, &sio_data);
+		err = f71882fg_find(addrs[i], &hwmon_addr, &sio_data);
 		if (err == 0)
 			break;
 	}
@@ -2375,7 +2375,7 @@ static int __init f71882fg_init(void)
 	if (err)
 		goto exit;
 
-	err = f71882fg_device_add(address, &sio_data);
+	err = f71882fg_device_add(hwmon_addr, &sio_data);
 	if (err)
 		goto exit_driver;
 
-- 
1.6.4.4


  reply	other threads:[~2010-03-23 23:12 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 14:12 [PATCH] hwmon: f71882fg: properly acquire I/O regions while probing Giel van Schijndel
2010-03-23 14:17 ` Giel van Schijndel
2010-03-23 23:12   ` [PATCH 1/4] [RFC] hwmon: f71882fg: Add support for the Fintek F71808E Giel van Schijndel
2010-03-23 23:12     ` Giel van Schijndel [this message]
2010-03-23 23:12       ` [PATCH 3/4] hwmon: f71882fg: add watchdog detection code Giel van Schijndel
2010-03-23 23:12         ` [PATCH 4/4] [RFC] hwmon: f71882fg: Add watchdog API for F71808E and F71889 Giel van Schijndel
2010-03-23 23:26           ` Giel van Schijndel
2010-03-24  8:37           ` Hans de Goede
2010-03-24  9:36             ` Giel van Schijndel
2010-03-24 10:33               ` Hans de Goede
2010-03-24 15:35                 ` Giel van Schijndel
2010-03-24 15:51                   ` Alan Cox
2010-03-24 16:20                     ` Hans de Goede
2010-03-24 20:35                       ` Giel van Schijndel
2010-04-25 21:20                         ` [lm-sensors] " Jim Cromie
2010-03-25  8:54                     ` Giel van Schijndel
2010-03-25 10:40                       ` Giel van Schijndel
2010-03-25 12:50                         ` Alan Cox
2010-03-25 13:06                           ` Hans de Goede
2010-03-25 13:17                           ` [PATCH 1/3] resource: shared I/O region support Giel van Schijndel
2010-03-25 13:17                             ` [PATCH 2/3] hwmon: f71882fg: use a muxed resource lock for the Super I/O port Giel van Schijndel
2010-03-25 13:17                               ` [PATCH 3/3] [RFC] watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E Giel van Schijndel
2010-03-30  9:06                                 ` Giel van Schijndel
2010-05-20  7:52                                   ` Wim Van Sebroeck
2010-05-25 21:08                                     ` Giel van Schijndel
2010-05-26  7:38                                       ` Wim Van Sebroeck
2010-07-31 21:36                                         ` Giel van Schijndel
2010-03-25 21:10                               ` [PATCH 2/3] hwmon: f71882fg: use a muxed resource lock for the Super I/O port Hans de Goede
2010-04-25 10:35                               ` Giel van Schijndel
2010-07-31 21:21                                 ` Giel van Schijndel
2010-03-25 15:57                             ` [PATCH 1/3] resource: shared I/O region support Alan Cox
2010-03-25 18:03                               ` Giel van Schijndel
2010-03-25 18:16                                 ` Alan Cox
2010-03-29  8:18                                   ` Giel van Schijndel
2010-03-29 16:07                                     ` Jesse Barnes
2010-03-29 17:38                                       ` Giel van Schijndel
2010-03-29 17:44                                         ` Giel van Schijndel
2010-03-29 17:45                                         ` H. Peter Anvin
2010-03-29 18:06                                           ` Jesse Barnes
2010-03-29 18:17                                             ` H. Peter Anvin
2010-03-29 18:29                                             ` Alan Cox
2010-04-02 20:29                                               ` Jesse Barnes
2010-03-29 18:39                                           ` Alan Cox
2010-03-29 18:56                                             ` H. Peter Anvin
2010-03-29 17:59                                         ` Jesse Barnes
2010-03-29 17:59                                         ` Jesse Barnes
2010-03-24  8:26       ` [PATCH 2/4] hwmon: f71882fg: prepare for addition of watchdog support Hans de Goede
2010-03-24  8:36       ` Hans de Goede
2010-03-24  8:25     ` [PATCH 1/4] [RFC] hwmon: f71882fg: Add support for the Fintek F71808E Hans de Goede
2010-03-24  9:23       ` [PATCH 1/4] " Giel van Schijndel
2010-03-24 10:31         ` Hans de Goede
2010-07-31 23:31           ` Giel van Schijndel
2010-08-01  6:12             ` Hans de Goede
2010-08-01 13:22               ` Giel van Schijndel
2010-08-01 13:30                 ` [PATCH] " Giel van Schijndel
2010-08-04 11:36                   ` Hans de Goede
2010-08-04 15:44                     ` Giel van Schijndel
2010-08-13 10:56                       ` Hans de Goede
2010-08-10 19:11                     ` Giel van Schijndel
2010-08-13 10:01                       ` Hans de Goede
2010-08-18 18:24                         ` Andrew Morton
2010-08-22 18:04                           ` Hans de Goede
2010-08-22 18:28                             ` Giel van Schijndel
2010-08-01 13:30                 ` [PATCH 1/2] hwmon: f71882fg: use a muxed resource lock for the Super I/O port Giel van Schijndel
2010-08-01 13:30                   ` [PATCH 2/2] watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E and F71882FG Giel van Schijndel
2010-08-04 11:38                   ` [PATCH 1/2] hwmon: f71882fg: use a muxed resource lock for the Super I/O port Hans de Goede
2010-10-02 22:59                     ` Giel van Schijndel
2010-10-03  1:06                       ` Guenter Roeck
2010-10-03  9:01                         ` Jean Delvare
2010-10-03 12:09                         ` [PATCH] " Giel van Schijndel
2010-10-03 13:31                           ` Guenter Roeck
2010-03-23 23:01 ` [PATCH] hwmon: f71882fg: properly acquire I/O regions while probing Giel van Schijndel
2010-03-24  8:14 ` Hans de Goede
2010-03-24  8:46   ` Giel van Schijndel
2010-03-24  9:09     ` [PATCH] hwmon: f71882fg: code cleanup Giel van Schijndel
2010-03-24 12:54       ` Jean Delvare
2010-03-24  9:09     ` [PATCH] hwmon: f71882fg: acquire I/O regions while we're working with them Giel van Schijndel
2010-03-24  9:28     ` [PATCH] hwmon: f71882fg: properly acquire I/O regions while probing Jean Delvare
2010-03-24  9:29 ` Jean Delvare
2010-03-24  9:34   ` Giel van Schijndel
2010-03-24 12:54     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269385936-3440-2-git-send-email-me@mortis.eu \
    --to=me@mortis.eu \
    --cc=hdegoede@redhat.com \
    --cc=jic23@cam.ac.uk \
    --cc=khali@linux-fr.org \
    --cc=laurens@signips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).