Re: [PATCH 1/2] sis-agp: Remove SIS 760, handled by amd64-agp

Dave Airlie
2010-03-26T02:31:32Z

On Fri, Mar 26, 2010 at 12:10 PM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
> On Fri, 26 Mar 2010 11:45:50 +1000
> Dave Airlie <airlied@gmail.com> wrote:
>
>> On Fri, Mar 26, 2010 at 11:41 AM, FUJITA Tomonori
>> <fujita.tomonori@lab.ntt.co.jp> wrote:
>> > On Wed, 24 Mar 2010 03:33:48 +0000
>> > Ben Hutchings <ben@decadent.org.uk> wrote:
>> >
>> >> SIS 760 is listed in the device tables for both amd64-agp and sis-agp.
>> >> amd64-agp is apparently preferable since it has workarounds for some
>> >> BIOS misconfigurations that sis-agp doesn't handle.
>> >>
>>
>> Will this not cause problems in 32-bit kernels?
>
> I'm not sure. I thought that amd64-agp works on 32-bit kernels since
> fix_northbridge() in amd64-agp.c has the comment that the function is
> used on 64-bit and 32-bit kernels. We need someone who can test the
> patch.
>

Ah yes the amd64-agp bit scared me again, I thought it was a 64-bit only
module, but it seems to get used on 32-bit as well.

Dave.