Re: [PATCH 1/2] sis-agp: Remove SIS 760, handled by amd64-agp

Ben Hutchings
2010-03-26T03:07:38Z

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

On Fri, 2010-03-26 at 10:41 +0900, FUJITA Tomonori wrote:
> On Wed, 24 Mar 2010 03:33:48 +0000
> Ben Hutchings <ben@decadent.org.uk> wrote:
>
> > SIS 760 is listed in the device tables for both amd64-agp and sis-agp.
> > amd64-agp is apparently preferable since it has workarounds for some
> > BIOS misconfigurations that sis-agp doesn't handle.
> >
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > drivers/char/agp/sis-agp.c | 8 --------
> > 1 files changed, 0 insertions(+), 8 deletions(-)
>
> Looks fine to me. Hopefully, amd64-agp can handle all SIS 760 systems.
>
> Can we confirm that this can fix bugs reported in Debian's bug
> tracking system (which you mentioned earlier)?
[...]

The bug involves amd64-agp screwing with a device that is already bound
to sis-agp. This patch should be sufficient to work around that. But
the second patch, to amd64-agp, should actually fix it. This is not
confirmed but I can try to get the bug submitters to test it.

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]