From: Richard Kennedy <richard@rsk.demon.co.uk>
To: rostedt@goodmis.org
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH] trace: reorder struct ring_buffer_per_cpu to remove padding on 64bit
Date: Thu, 25 Mar 2010 13:44:03 +0000 [thread overview]
Message-ID: <1269524643.2054.13.camel@localhost> (raw)
In-Reply-To: <1269524290.2957.4073.camel@gandalf.stny.rr.com>
On Thu, 2010-03-25 at 09:38 -0400, Steven Rostedt wrote:
> On Thu, 2010-03-25 at 11:27 +0000, Richard Kennedy wrote:
> > Reorder structure to remove 8 bytes of padding on 64 bit builds.
> > This shrinks the size to 128 bytes so allowing allocation from a smaller
> > slab & needed one fewer cache lines.
> >
>
> Thanks!
>
> Just curious, did you use Arnaldo's pahole utility to find this?
>
> -- Steve
No, but something similar I guess. I wrote my own tool that parses the
debug data & filters out the interesting results ;)
Richard
next prev parent reply other threads:[~2010-03-25 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 11:27 [PATCH] trace: reorder struct ring_buffer_per_cpu to remove padding on 64bit Richard Kennedy
2010-03-25 13:38 ` Steven Rostedt
2010-03-25 13:44 ` Richard Kennedy [this message]
2010-07-23 12:10 ` [tip:perf/core] trace: Reorder " tip-bot for Richard Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269524643.2054.13.camel@localhost \
--to=richard@rsk.demon.co.uk \
--cc=acme@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox