public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] sis-agp: Remove SIS 760, handled by amd64-agp
Date: Fri, 26 Mar 2010 03:07:26 +0000	[thread overview]
Message-ID: <1269572846.8653.39.camel@localhost> (raw)
In-Reply-To: <20100326104042T.fujita.tomonori@lab.ntt.co.jp>

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

On Fri, 2010-03-26 at 10:41 +0900, FUJITA Tomonori wrote:
> On Wed, 24 Mar 2010 03:33:48 +0000
> Ben Hutchings <ben@decadent.org.uk> wrote:
> 
> > SIS 760 is listed in the device tables for both amd64-agp and sis-agp.
> > amd64-agp is apparently preferable since it has workarounds for some
> > BIOS misconfigurations that sis-agp doesn't handle.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> >  drivers/char/agp/sis-agp.c |    8 --------
> >  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> Looks fine to me. Hopefully, amd64-agp can handle all SIS 760 systems.
> 
> Can we confirm that this can fix bugs reported in Debian's bug
> tracking system (which you mentioned earlier)?
[...]

The bug involves amd64-agp screwing with a device that is already bound
to sis-agp.  This patch should be sufficient to work around that.  But
the second patch, to amd64-agp, should actually fix it.  This is not
confirmed but I can try to get the bug submitters to test it.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  parent reply	other threads:[~2010-03-26  3:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24  3:33 [PATCH 1/2] sis-agp: Remove SIS 760, handled by amd64-agp Ben Hutchings
2010-03-26  1:41 ` FUJITA Tomonori
2010-03-26  1:45   ` Dave Airlie
2010-03-26  2:10     ` FUJITA Tomonori
2010-03-26  2:31       ` Dave Airlie
2010-03-26  3:07   ` Ben Hutchings [this message]
2010-05-16  1:08 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269572846.8653.39.camel@localhost \
    --to=ben@decadent.org.uk \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox