From: Peter Zijlstra <peterz@infradead.org>
To: Julia Lawall <julia@diku.dk>
Cc: Ingo Molnar <mingo@elte.hu>, tglx <tglx@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: set_cpus_allowed_ptr
Date: Fri, 26 Mar 2010 12:52:38 +0100 [thread overview]
Message-ID: <1269604358.12097.143.camel@laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.1003261218410.27328@ask.diku.dk>
On Fri, 2010-03-26 at 12:22 +0100, Julia Lawall wrote:
> On Fri, 26 Mar 2010, Peter Zijlstra wrote:
>
> > Hi,
> >
> > Would it make sense to clean up the set_cpus_allowed() vs
> > set_cpus_allowed_ptr() mess using the semantic patch tool?
> >
> > I guess it would be three patches:
> > 1) converting the current remaining set_cpus_allowed() users into
> > set_cpus_allowed_ptr().
> > 2) remove set_cpus_allowed().
> > 3) rename set_cpus_allowed_ptr() to set_cpus_allowed()
>
> Perhaps a subtlety is that set_cpus_allowed is creating a new variable,
> whose address it sends to set_cpus_allowed_ptr?
Yes it does that, but I don't think that actually matters,
set_cpus_allowed_ptr()'s arg is const, so making that temporary copy
shouldn't have any side effects.
next prev parent reply other threads:[~2010-03-26 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 10:03 set_cpus_allowed_ptr Peter Zijlstra
2010-03-26 11:22 ` set_cpus_allowed_ptr Julia Lawall
2010-03-26 11:52 ` Peter Zijlstra [this message]
2010-03-26 16:38 ` set_cpus_allowed_ptr Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269604358.12097.143.camel@laptop \
--to=peterz@infradead.org \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox