Re: [PATCH] rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe

FUJITA Tomonori
2010-03-29T01:52:26Z

On Mon, 29 Mar 2010 01:24:45 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:

> To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
> change the type of the first parameter to linux_pci_{map,unmap}_single()
> from void * to struct rt_rtmp_adapter *. Also do not define the macros
> PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
> not used and if they were that would be a bug.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/staging/rt2860/rt_linux.h | 14 +++++---------
> drivers/staging/rt2860/rt_pci_rbus.c | 12 ++++--------
> 2 files changed, 9 insertions(+), 17 deletions(-)

I think using dma_map_single directly instead of inventing a wrapper
function make the code more readable.