public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Rik van Riel <riel@redhat.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: KVM bug, git bisected
Date: Mon, 29 Mar 2010 18:29:00 +0200	[thread overview]
Message-ID: <1269880140.12097.356.camel@laptop> (raw)
In-Reply-To: <4BB0D11A.607@redhat.com>

On Mon, 2010-03-29 at 12:11 -0400, Rik van Riel wrote:
> On 03/27/2010 08:43 AM, Kent Overstreet wrote:
> > commit 5beb49305251e5669852ed541e8e2f2f7696c53e
> > Author: Rik van Riel <riel@redhat.com>
> > Date: Fri Mar 5 13:42:07 2010 -0800
> >
> > mm: change anon_vma linking to fix multi-process server scalability issue
> >
> > I get this when starting kvm. The warning hasn't caused me problems, but
> > I've also been getting a scheduling while atomic panic when I start kvm
> > that I can only reproduce when I don't want to. It's definitely config
> > dependent, I'd guess preempt might have something to do with it.
> 
>  From your trace, it looks like mm_take_all_locks is taking close
> to 256 locks, which is where the preempt_count could overflow into
> the softirq count.
> 
> Since kvm-qemu is exec'd, I am guessing you have a very large
> number of VMAs in your qemu process.  Is that correct?
> 
> Peter, would it be safe to increase PREEMPT_BITS to eg. 10?

Possibly, but who's to say the thing won't bloat to 65k at which it'll
hit the vma limit, but even that can be grown beyond that.

When we started out with this I predicted this would happen, the
following was said:

---
> When we created this the promise was that kvm would only do this on a
> fresh mm with only a few vmas, has that changed?

The number of vmas did increase, but not materially.  We do link with 
more shared libraries though.
---

That was when we broke the 48 barrier (jul'09), apparently we've now
bloated to beyond 256, at this rate 10 will not last 6 months.

Alternative we remove the preempt overflow warning, it shouldn't break,
although it all is very ugly..



  parent reply	other threads:[~2010-03-29 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-27 12:43 KVM bug, git bisected Kent Overstreet
2010-03-29 16:11 ` Rik van Riel
2010-03-29 16:27   ` Rik van Riel
2010-03-29 16:29   ` Peter Zijlstra [this message]
2010-03-29 16:44     ` Peter Zijlstra
2010-03-30  0:34       ` KOSAKI Motohiro
2010-03-29 22:23     ` Dave Chinner
2010-04-01 18:58 ` Maciej Rutecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269880140.12097.356.camel@laptop \
    --to=peterz@infradead.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox