Re: [PATCH] hangcheck-timer is broken on x86

john stultz
2010-03-29T01:01:19Z

On Fri, 2010-03-26 at 14:46 -0700, Joel Becker wrote:
> On Tue, Mar 23, 2010 at 11:36:11PM -0400, Yury Polyanskiy wrote:
> > Second, and more importantly, loops_per_jiffy has little to do with the conversion from the
> > the time scale of get_cycles() (aka rdtsc) to the time scale of jiffies.
>
> It used to! Fundamentally, of course, we didn't have a
> monotonic clock everywhere that satisfied hangcheck-timer's needs. So
> we had to use different approaches on different architectures.
>
> > @@ -130,7 +129,9 @@ extern unsigned long long monotonic_clock(void);
> > #else
> > static inline unsigned long long monotonic_clock(void)
> > {
> > - return get_cycles();
> > + struct timespec ts;
> > + getrawmonotonic(&ts);
> > + return timespec_to_ns(&ts);
> > }
> > #endif /* HAVE_MONOTONIC */
>
> I have two questions:
>
> 1) Does getrawmonotonic() satisfy hangcheck-timer? What I mean is, will
> it always return the wallclock nanoseconds even in the face of CPU speed
> changes, suspend, udelay, or any other suspension of kernel operation?
> Yes, I know this is a tougher standard than rdtsc(), but this is what
> hangcheck-timer wants. rdtsc() at least satisfied udelay and PCI hangs.

getrawmonotonic() can be stalled and will wrap on some hardware (acpi pm
timer wraps every 5 seconds).

I think the read_persistent_clock() is really what you want to use here.
On arches that do not support it, it returns 0 every time.

thanks
-john