Re: [PATCH] hangcheck-timer is broken on x86

Yury Polyanskiy
2010-03-28T13:02:34Z

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

On Sat, 27 Mar 2010 16:36:30 -0700
Joel Becker <Joel.Becker@oracle.com> wrote:

> On Sat, Mar 27, 2010 at 06:51:01PM -0400, Yury Polyanskiy wrote:
> > >        It's OK to tell hangcheck-timer users that suspend is not
> > > allowed.  After all, you're running something that you don't want to see
> > > hang.
> >
> > Joel, what I am saying is exactly the opposite: it is totally ok to
> > suspend-resume with hangcheck-timer (jiffies are stopped and so is
> > getrawmonotonic() when system suspended).
>
> Nope. The point of hangcheck-timer is that it reboots should
> the system not be running for a certain amountof time. If
> suspend-resume is allowed, a system can resume after days and think it
> wasn't more than a second. hangcheck-timer will not know to reboot.

But what is the reason for rebooting? Hangcheck is supposed to reboot
the machine only if the timer handler was run too late. However,
jiffies-based timers DO NOT count time spent in suspend.

Y

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]