From: Joe Perches <joe@perches.com>
To: Luis de Bethencourt <luisbg@ubuntu.com>
Cc: linville@tuxdriver.com, lrodriguez@atheros.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ath: fix macros coding style issue in regd.c
Date: Mon, 29 Mar 2010 16:33:44 -0700 [thread overview]
Message-ID: <1269905624.4558.56.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1269904339-15599-1-git-send-email-luisbg@ubuntu.com>
On Tue, 2010-03-30 at 00:12 +0100, Luis de Bethencourt wrote:
> This is a patch to the ath/regd.c file that fixes up three warnings
> about macros found by the checkpatch.pl tool, these said that
> complex values should be enclosed in parenthesis.
Hi Luis.
Checkpatch isn't always correct.
Please make sure to compile test your changes
before submitting them.
These macros are used as initializers and
can not be surrounded by parentheses.
.reg_rules = {
ATH9K_2GHZ_ALL,
cheers, Joe
next prev parent reply other threads:[~2010-03-29 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <regd.c>
2010-03-29 23:12 ` [PATCH 2/2] ath: fix macros coding style issue in regd.c Luis de Bethencourt
2010-03-29 23:33 ` Joe Perches [this message]
2010-03-29 23:39 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269905624.4558.56.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=luisbg@ubuntu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox