Re: [PATCH] trace power_frequency events on the correct cpu (for Intel x86 CPUs)

Thomas Renninger
2010-03-20T21:37:57Z

> This wrapper would make things easier of course, since one might add the
> same line for every driver
...
It's simply broken and can't be fixed without chaninging the whole concept.
power_frequency_events() must not only pass the cpu, but a cpumask also for
acpi-cpufreq.
If you look at SW_ANY SW_ALL (or similar, I can't look at code right now)
parts, acpi-cpufreq can change the frequency for several cores with one MSR
write.
AFAIK this is for example the recommended way for Dunnington (6 cores).
So the collected data can be totally wrong.
Better remove this before others also start to use it.
It also seem to be (hopefully) a minor feature for timechart, so this should
not hurt that much (yet).

Thomas