From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
John Kacur <jkacur@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Al Viro <viro@ZenIV.linux.org.uk>, Ingo Molnar <mingo@elte.hu>
Subject: [PATCH 2/6] procfs: Use generic_file_llseek in /proc/kcore
Date: Tue, 30 Mar 2010 08:20:11 +0200 [thread overview]
Message-ID: <1269930015-863-3-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1269930015-863-1-git-send-regression-fweisbec@gmail.com>
/proc/kcore has no llseek and then falls down to use default_llseek.
This is racy against read_kcore() that directly manipulates fpos
but it doesn't hold the bkl there so using it in llseek doesn't
protect anything.
Let's use generic_file_llseek() instead.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: John Kacur <jkacur@redhat.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
---
fs/proc/kcore.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index a44a789..da21060 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -557,6 +557,7 @@ static int open_kcore(struct inode *inode, struct file *filp)
static const struct file_operations proc_kcore_operations = {
.read = read_kcore,
.open = open_kcore,
+ .llseek = generic_file_llseek,
};
#ifdef CONFIG_MEMORY_HOTPLUG
--
1.6.2.3
next prev parent reply other threads:[~2010-03-30 6:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 6:20 [PATCH 0/6] Kill the bkl in procfs Frederic Weisbecker
2010-03-30 6:20 ` [PATCH 1/6] procfs: Kill BKL in llseek on proc base Frederic Weisbecker
2010-03-30 6:40 ` Alexey Dobriyan
2010-03-30 6:50 ` Frederic Weisbecker
2010-03-30 6:20 ` Frederic Weisbecker [this message]
2010-03-30 10:28 ` [PATCH 2/6] procfs: Use generic_file_llseek in /proc/kcore Arnd Bergmann
2010-03-30 6:20 ` [PATCH 3/6] procfs: Use generic_file_llseek in /proc/kmsg Frederic Weisbecker
2010-03-30 10:38 ` Arnd Bergmann
2010-03-30 6:20 ` [PATCH 4/6] procfs: Use generic_file_llseek in /proc/vmcore Frederic Weisbecker
2010-03-30 10:38 ` Arnd Bergmann
2010-03-30 6:20 ` [PATCH 5/6] procfs: Push down the bkl from ioctl Frederic Weisbecker
2010-03-30 6:31 ` Alexey Dobriyan
2010-03-30 7:02 ` Frederic Weisbecker
2010-04-09 14:45 ` [PATCH v2] " Frederic Weisbecker
2010-04-10 13:25 ` [PATCH v3] " Frederic Weisbecker
2010-05-17 1:23 ` [PATCH v4] " Frederic Weisbecker
2010-03-30 10:37 ` [PATCH 5/6] " Arnd Bergmann
2010-03-30 18:27 ` Frederic Weisbecker
2010-03-30 18:54 ` Arnd Bergmann
2010-03-30 19:21 ` Frederic Weisbecker
2010-03-30 6:20 ` [PATCH 6/6] procfs: Kill the bkl in ioctl Frederic Weisbecker
2010-03-30 6:38 ` Alexey Dobriyan
2010-03-30 7:07 ` Frederic Weisbecker
2010-03-30 10:33 ` Arnd Bergmann
2010-03-31 17:22 ` Frederic Weisbecker
2010-03-31 20:21 ` Arnd Bergmann
2010-03-31 21:04 ` Arnd Bergmann
2010-03-31 21:55 ` Alan Cox
2010-04-01 9:07 ` Arnd Bergmann
2010-03-31 21:56 ` Frederic Weisbecker
2010-04-01 11:37 ` Arnd Bergmann
2010-04-01 10:22 ` John Kacur
2010-03-31 21:41 ` Frederic Weisbecker
2010-04-01 12:42 ` Arnd Bergmann
2010-04-03 17:53 ` Stefan Richter
2010-04-10 16:09 ` Frederic Weisbecker
2010-04-12 15:05 ` Arnd Bergmann
2010-04-10 16:14 ` Frederic Weisbecker
2010-04-10 16:24 ` Frederic Weisbecker
2010-04-01 11:39 ` Stefan Richter
2010-04-01 12:45 ` Arnd Bergmann
2010-04-10 15:28 ` Frederic Weisbecker
2010-04-11 13:03 ` Christoph Hellwig
2010-04-12 17:34 ` Arnd Bergmann
2010-04-12 21:53 ` Frederic Weisbecker
2010-04-13 9:26 ` Arnd Bergmann
2010-04-13 20:10 ` Frederic Weisbecker
2010-04-13 18:03 ` Christoph Hellwig
2010-04-10 13:27 ` [PATCH 0/6] Kill the bkl in procfs Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269930015-863-3-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=jkacur@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).