* [PATCH]slub: fix bad scope checking
@ 2010-04-01 9:32 Zhang, Yanmin
2010-04-01 16:00 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Yanmin @ 2010-04-01 9:32 UTC (permalink / raw)
To: Christoph Lameter; +Cc: LKML, Pekka Enberg
Function init_kmem_cache_nodes is incorrect when checking upper limitation
of kmalloc_caches.
The patch against latest tip/master fixes it.
From: Zhang, Yanmin <yanmin_zhang@linux.intel.com>
---
--- linux-2.6/mm/slub.c 2010-04-01 17:01:21.091999999 +0800
+++ linux-2.6_slub/mm/slub.c 2010-04-01 17:04:34.876000010 +0800
@@ -2153,7 +2153,7 @@ static int init_kmem_cache_nodes(struct
int local_node;
if (slab_state >= UP && (s < kmalloc_caches ||
- s > kmalloc_caches + KMALLOC_CACHES))
+ s >= kmalloc_caches + KMALLOC_CACHES))
local_node = page_to_nid(virt_to_page(s));
else
local_node = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]slub: fix bad scope checking
2010-04-01 9:32 [PATCH]slub: fix bad scope checking Zhang, Yanmin
@ 2010-04-01 16:00 ` Christoph Lameter
2010-04-02 7:03 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2010-04-01 16:00 UTC (permalink / raw)
To: Zhang, Yanmin; +Cc: LKML, Pekka Enberg
On Thu, 1 Apr 2010, Zhang, Yanmin wrote:
> Function init_kmem_cache_nodes is incorrect when checking upper limitation
> of kmalloc_caches.
True.
Acked-by: Christoph Lameter <cl@linux-foundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]slub: fix bad scope checking
2010-04-01 16:00 ` Christoph Lameter
@ 2010-04-02 7:03 ` Pekka Enberg
0 siblings, 0 replies; 3+ messages in thread
From: Pekka Enberg @ 2010-04-02 7:03 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Zhang, Yanmin, LKML
Christoph Lameter wrote:
> On Thu, 1 Apr 2010, Zhang, Yanmin wrote:
>
>> Function init_kmem_cache_nodes is incorrect when checking upper limitation
>> of kmalloc_caches.
>
> True.
>
> Acked-by: Christoph Lameter <cl@linux-foundation.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-02 7:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-01 9:32 [PATCH]slub: fix bad scope checking Zhang, Yanmin
2010-04-01 16:00 ` Christoph Lameter
2010-04-02 7:03 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).