From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ferenc Wagner <wferi@niif.hu>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry
Date: Thu, 01 Apr 2010 15:27:22 +0300 [thread overview]
Message-ID: <1270124842.15073.61.camel@localhost> (raw)
In-Reply-To: <87aaul1d67.fsf@tac.ki.iif.hu>
On Sat, 2010-03-06 at 20:08 +0100, Ferenc Wagner wrote:
> Actually, this embedded struct (together with nandsim_regs) could as well
> remain nameless...
>
> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
> ---
> drivers/mtd/nand/nandsim.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 7281000..803ae12 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -312,7 +312,7 @@ struct nandsim {
> union ns_mem buf;
>
> /* NAND flash "geometry" */
> - struct nandsin_geometry {
> + struct nandsim_geometry {
> uint64_t totsz; /* total flash size, bytes */
> uint32_t secsz; /* flash sector (erase block) size, bytes */
> uint pgsz; /* NAND flash page size, bytes */
Instead of taking your patch, I've made this structure anonymous as well
as few other structures. See
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/833ba5e74a8b141ea7d7b318d6ac8c112659efa6
I've referred you as the person who suggested the change.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-04-01 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-06 19:08 [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry Ferenc Wagner
2010-03-12 22:56 ` Andrew Morton
2010-04-01 12:27 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270124842.15073.61.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox