* Re: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry
2010-03-06 19:08 [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry Ferenc Wagner
@ 2010-03-12 22:56 ` Andrew Morton
2010-04-01 12:27 ` Artem Bityutskiy
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2010-03-12 22:56 UTC (permalink / raw)
To: Ferenc Wagner; +Cc: linux-mtd, linux-kernel
On Sat, 06 Mar 2010 20:08:00 +0100
Ferenc Wagner <wferi@niif.hu> wrote:
> Subject: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry
fyi, the text inside [] is conventionally considered "transient, to be
removed by receiver", so you should have placed the
subsystem-identification text outside the [].
> Actually, this embedded struct (together with nandsim_regs) could as well
> remain nameless...
>
Sounds like a fine idea.
> ---
> drivers/mtd/nand/nandsim.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 7281000..803ae12 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -312,7 +312,7 @@ struct nandsim {
> union ns_mem buf;
>
> /* NAND flash "geometry" */
> - struct nandsin_geometry {
> + struct nandsim_geometry {
> uint64_t totsz; /* total flash size, bytes */
> uint32_t secsz; /* flash sector (erase block) size, bytes */
> uint pgsz; /* NAND flash page size, bytes */
this:
From: Ferenc Wagner <wferi@niif.hu>
The name was spelled wrong. We don't need an identifier on this struct
anyway, so remove it altogether.
Signed-off-by: Ferenc Wagner <wferi@niif.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mtd/nand/nandsim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry drivers/mtd/nand/nandsim.c
--- a/drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry
+++ a/drivers/mtd/nand/nandsim.c
@@ -315,7 +315,7 @@ struct nandsim {
union ns_mem buf;
/* NAND flash "geometry" */
- struct nandsin_geometry {
+ struct {
uint64_t totsz; /* total flash size, bytes */
uint32_t secsz; /* flash sector (erase block) size, bytes */
uint pgsz; /* NAND flash page size, bytes */
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry
2010-03-06 19:08 [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry Ferenc Wagner
2010-03-12 22:56 ` Andrew Morton
@ 2010-04-01 12:27 ` Artem Bityutskiy
1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2010-04-01 12:27 UTC (permalink / raw)
To: Ferenc Wagner; +Cc: linux-mtd, linux-kernel
On Sat, 2010-03-06 at 20:08 +0100, Ferenc Wagner wrote:
> Actually, this embedded struct (together with nandsim_regs) could as well
> remain nameless...
>
> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
> ---
> drivers/mtd/nand/nandsim.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 7281000..803ae12 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -312,7 +312,7 @@ struct nandsim {
> union ns_mem buf;
>
> /* NAND flash "geometry" */
> - struct nandsin_geometry {
> + struct nandsim_geometry {
> uint64_t totsz; /* total flash size, bytes */
> uint32_t secsz; /* flash sector (erase block) size, bytes */
> uint pgsz; /* NAND flash page size, bytes */
Instead of taking your patch, I've made this structure anonymous as well
as few other structures. See
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/833ba5e74a8b141ea7d7b318d6ac8c112659efa6
I've referred you as the person who suggested the change.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 3+ messages in thread