Re: [COUNTERPATCH] mm: avoid overflowing preempt_count() in mmu_take_all_locks()

Avi Kivity
2010-04-01T16:37:39Z

On 04/01/2010 02:43 PM, Peter Zijlstra wrote:
> On Thu, 2010-04-01 at 13:27 +0200, Peter Zijlstra wrote:
>
>> I've almost got a patch done that converts those two, still need to look
>> where that tasklist_lock muck happens.
>>
> OK, so the below builds and boots, only need to track down that
> tasklist_lock nesting, but I got to run an errand first.
>
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -327,7 +327,7 @@ static void drop_anon_vma(struct rmap_item *rmap_item)
>
> if (atomic_dec_and_lock(&anon_vma->ksm_refcount,&anon_vma->lock)) {
> int empty = list_empty(&anon_vma->head);
> - spin_unlock(&anon_vma->lock);
> + mutex_unlock(&anon_vma->lock);
> if (empty)
> anon_vma_free(anon_vma);
> }
>

You need to convert the atomic_dec_and_lock() as well.

--
error compiling committee.c: too many arguments to function